Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs still point to bitbucket repo #70

Closed
nicain opened this issue Aug 10, 2017 · 5 comments
Closed

Docs still point to bitbucket repo #70

nicain opened this issue Aug 10, 2017 · 5 comments

Comments

@nicain
Copy link
Contributor

nicain commented Aug 10, 2017

Some of the docs still point to the pre-migration bitbucket repository

Here is a screen cap listing some of the locations, there might be more:
image

@jhyearsley, do you want to take a stab at correcting these, and submitting a PR?

@jhyearsley
Copy link
Contributor

Definitely, I will look into this tomorrow.

@jhyearsley
Copy link
Contributor

I've changed the simple links from the screen shot that can just be pointed directly to github, but there are other links referencing content on bitbucket that I don't have access to (or doesn't exist).

For instance in the setup.py file, the source of the nwb schema is downloaded from a bitbucket link in a downloads folder hosted on bitbucket, and I'm not sure where the nwb_core.tar file lives now.

There are also references in some of the Jupyter notebooks to issues hosted on bitbucket that are broken links. Not sure what the thought process is on that. One solution is to just remove the links but I will wait for suggestions before editing that.

@oruebel
Copy link
Contributor

oruebel commented Aug 15, 2017

I've fixed the references in the current notebooks. I've searched through both the pynwb and nwb-schema repo, and it looks like the only relevant instance that still requires fixing is in the function CustomBuild in setup.py which references a tar file on bitbucket. @ajtritt can you check whether that link needs to be updated.

@ajtritt
Copy link
Member

ajtritt commented Aug 15, 2017

@oruebel that link does not need to be updated. That class can be removed from setup.py

@oruebel
Copy link
Contributor

oruebel commented Aug 15, 2017

@ajtritt thanks for the quick response. I'll remove the class and close this ticket.

oruebel added a commit that referenced this issue Aug 15, 2017
Removed CustomBuild class from setup.py. Fix #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants