Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run each test-suite independently and label associated coverage report #160

Merged
merged 1 commit into from Oct 23, 2017

Conversation

jcfr
Copy link
Collaborator

@jcfr jcfr commented Oct 20, 2017

See #159

Suggested-by: Andrew Tritt ajtritt@lbl.gov

@jcfr jcfr requested a review from dorukozturk October 20, 2017 05:01
@jcfr jcfr added the category: enhancement improvements of code or code behavior label Oct 20, 2017
@jcfr
Copy link
Collaborator Author

jcfr commented Oct 20, 2017

Look like the python implementation of codecov CLI does not support the -C parameter. See https://docs.codecov.io/docs/flags

…eport

See #159

Suggested-by: Andrew Tritt <ajtritt@lbl.gov>
@jcfr jcfr force-pushed the associate-codecov-flag-for-each-testsuite branch from fb42e58 to 9685f40 Compare October 20, 2017 05:11
@codecov-io
Copy link

codecov-io commented Oct 20, 2017

Codecov Report

Merging #160 into dev will decrease coverage by 26.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #160       +/-   ##
==========================================
- Coverage   85.76%   59.7%   -26.07%     
==========================================
  Files          39      39               
  Lines        4075    4075               
==========================================
- Hits         3495    2433     -1062     
- Misses        580    1642     +1062
Flag Coverage Δ
#form 59.7% <ø> (?)
#integration 59.7% <ø> (?)
#pynwb 59.7% <ø> (?)
Impacted Files Coverage Δ
src/form/validate/validator.py 18.22% <0%> (-70.1%) ⬇️
src/form/build/builders.py 28.16% <0%> (-69.02%) ⬇️
src/form/backends/hdf5/h5tools.py 14.46% <0%> (-68.52%) ⬇️
src/pynwb/io/file.py 28% <0%> (-68%) ⬇️
src/pynwb/io/base.py 40.74% <0%> (-59.26%) ⬇️
src/form/build/map.py 35.7% <0%> (-52.9%) ⬇️
src/form/data_utils.py 40.41% <0%> (-49.23%) ⬇️
src/form/validate/errors.py 41.46% <0%> (-41.47%) ⬇️
src/form/backends/io.py 46.34% <0%> (-39.03%) ⬇️
src/form/container.py 80% <0%> (-20%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7470b...9685f40. Read the comment docs.

@jcfr
Copy link
Collaborator Author

jcfr commented Oct 20, 2017

For each tile, there is now a list of toggle button associated with each flags:

ci-coverage-toggle

@jcfr
Copy link
Collaborator Author

jcfr commented Oct 20, 2017

That said, I suspect we need to clean up the previous coverage report between each run of test suite.

This is available in the bash implementation of the codecov client but not in the python one

@jcfr
Copy link
Collaborator Author

jcfr commented Oct 23, 2017

Also, it look like I am not authorized to merge pull request.

Would it be possible to grant me the right or proceed with the merge .. thanks

@ajtritt ajtritt merged commit 9b5100f into dev Oct 23, 2017
@jcfr jcfr deleted the associate-codecov-flag-for-each-testsuite branch November 7, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants