-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not create a fat jar with dependencies. #98
Conversation
Dependency to commons-net is done by Import-Package OSGI instruction.
Found out that this issue also duplicates #44... |
Indeed, I had this wish much earlier ;-) |
Product is quite stable, so why should there be changes? @kaikreuzer did you make any changes in the code, that would be worth having here? |
Hey! This looks great, and I apologise for being out of the loop this past year. I will have time this summer, maybe we can work together to unify the changes and get a new release out? |
Then you do not use it enough :-)
@madhephaestus Sounds great, it would be awesome to revive this project again together. I would mainly like to invite @cvanorman as he prepared all the changes in the openHAB fork and should be able to provide PRs against the official repo as well. |
I also have to say that I appreciate the work done so far but there are also several issues that should be solved e.g. #97 ;-) @madhephaestus: A new release soon sounds good to me - also would contribute to it :-) |
@crea-doo @kaikreuzer @andyrozman I pulled together the outstanding PR's and made a release of 3.13.0 I have also created a development branch for receiving PR's in the future, as id like to have this look a bit more like gitflow. Hows this sound for a starting point? |
Thanks @madhephaestus, definitely a good starting point! A few comments about the 3.13.0 release:
|
I try to solve number 2 and provide a PR soon... |
It's not necessary to ship dependencies with the lib.
Changes taken from cvanorman#1 and msteigenberger@b9b36cb