Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create a fat jar with dependencies. #98

Merged
merged 1 commit into from
May 20, 2017

Conversation

crea-doo
Copy link
Contributor

It's not necessary to ship dependencies with the lib.

Changes taken from cvanorman#1 and msteigenberger@b9b36cb

Dependency to commons-net is done by Import-Package OSGI instruction.
@crea-doo
Copy link
Contributor Author

crea-doo commented May 18, 2017

Found out that this issue also duplicates #44...

@kaikreuzer
Copy link
Contributor

Indeed, I had this wish much earlier ;-)
FTR: In openHAB, we are maintaining this fork, which had been prepared by @cvanorman - I would hope to switch back to the official build again one day, but there doesn't seem much activity here anymore, which doesn't make me too confident...

@andyrozman
Copy link

Product is quite stable, so why should there be changes?

@kaikreuzer did you make any changes in the code, that would be worth having here?

@madhephaestus
Copy link
Member

Hey! This looks great, and I apologise for being out of the loop this past year. I will have time this summer, maybe we can work together to unify the changes and get a new release out?

@kaikreuzer
Copy link
Contributor

Product is quite stable, so why should there be changes?

Then you do not use it enough :-)
We were blocked by (non exhaustive list): #23, #28, #44, #60, #72, #73, #95, #96

I will have time this summer, maybe we can work together to unify the changes and get a new release out?

@madhephaestus Sounds great, it would be awesome to revive this project again together. I would mainly like to invite @cvanorman as he prepared all the changes in the openHAB fork and should be able to provide PRs against the official repo as well.

@crea-doo
Copy link
Contributor Author

I also have to say that I appreciate the work done so far but there are also several issues that should be solved e.g. #97 ;-)

@madhephaestus: A new release soon sounds good to me - also would contribute to it :-)

@madhephaestus madhephaestus merged commit 08f0a42 into NeuronRobotics:master May 20, 2017
@madhephaestus
Copy link
Member

@crea-doo @kaikreuzer @andyrozman I pulled together the outstanding PR's and made a release of 3.13.0 I have also created a development branch for receiving PR's in the future, as id like to have this look a bit more like gitflow. Hows this sound for a starting point?

@crea-doo crea-doo deleted the fat-jar branch May 21, 2017 07:28
@kaikreuzer
Copy link
Contributor

Thanks @madhephaestus, definitely a good starting point!

A few comments about the 3.13.0 release:

  1. Maven Central lists Apache license for this project - according to License information is missing in the repo #28 (comment), we should have LGPL, though.
  2. The generated MANIFEST.MF has mandatory package-imports for com.sun.jna.platform.win32and org.apache.commons.net.telnet - I think both would have to be optional only.
  3. You might want to close/clean-up https://github.com/NeuronRobotics/nrjavaserial/milestone/1.

@crea-doo
Copy link
Contributor Author

I try to solve number 2 and provide a PR soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants