Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon to match current webstore logo #118

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

easrng
Copy link
Contributor

@easrng easrng commented Feb 28, 2023

No description provided.

@NeverDecaf
Copy link
Owner

Good but I think the old icon should be used for 16px, 24px, and 32px, as the chrome web store still uses the old one in their favicon. (Also the new one looks pretty bad in the toolbar as it's a few pixels smaller than other 16px icons.)
image

@easrng
Copy link
Contributor Author

easrng commented Mar 2, 2023

I can resize them! They're all rendered from an svg (hope I saved it...) so it shouldn't be very difficult.

@NeverDecaf
Copy link
Owner

There is quite a bit of transparency around the edges of this new icon so I'm not sure how good it will look simply scaled up. The 16px version, for example, looks like it needs to be scaled to 21x21 and cropped to properly fill the 16x16 area. There may be a good reason Google didn't replace their favicon with this new design (another issue is the new color matches the toolbar a little too well and is almost invisible against the background as you can see in my screenshot.)

@NeverDecaf
Copy link
Owner

image
Here is what the old icon looks like for reference.

@easrng
Copy link
Contributor Author

easrng commented Mar 2, 2023

There may be a good reason Google didn't replace their favicon with this new design

I didn't notice that they didn't replace the smallest size, they replaced the larger sizes and firefox (which is what i usually use) scales down the larger ones for some reason.

@easrng
Copy link
Contributor Author

easrng commented Mar 2, 2023

ok, i updated the larger icons to match the colors and padding the chrome webstore uses for its actual favicons (instead of the icon in the header) and for the 3 smallest i edited the images to have the current chromium logo on the old background.

@NeverDecaf
Copy link
Owner

NeverDecaf commented Mar 2, 2023

Looks good except you missed the transparency in the handle part of the large bag, which will be an issue for those using any non-white theme image

edit: Just realized they actually did update the small icon slightly, making the handle a bit thinner:
https://www.google.com/images/icons/product/chrome_web_store-16.png
https://www.google.com/images/icons/product/chrome_web_store-24.png
https://www.google.com/images/icons/product/chrome_web_store-32.png
Not sure if you care enough to make your icons match this, I'm fine either way.

@easrng
Copy link
Contributor Author

easrng commented Mar 5, 2023

They didn't actually change the 24 or 32px ones

@easrng
Copy link
Contributor Author

easrng commented Mar 5, 2023

k, fixed 16, 48, 64, and 128 :)

@NeverDecaf
Copy link
Owner

Nice. Thank you!

@NeverDecaf NeverDecaf merged commit a3a5a89 into NeverDecaf:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants