Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mannually install option. #95

Merged
merged 1 commit into from
May 29, 2022
Merged

Add mannually install option. #95

merged 1 commit into from
May 29, 2022

Conversation

neo-sam
Copy link
Contributor

@neo-sam neo-sam commented May 14, 2022

avoid CRX_REQUIRED_PROOF_MISSING for vanilla Chromium browsers.

bandicam.2022-05-14.19-22-19-136.mp4

@NeverDecaf
Copy link
Owner

Looks good but I have a few concerns:

  1. As it is, this will only work on the Microsoft Edge Store, is this intentional?
  2. Opening chrome://extensions and showing a notification for every download needs to be limited because if a user uses the "Import" or "Update all extensions" features, they will be spammed with new tabs and notifications.
  3. "Manual" implies the opposite, "Auto," and I'm afraid that will cause more confusion about this extension, I would prefer a more precise name for this option, for example: Always download CRX files.

For 1, to make this work on the Chrome Web Store, you will need to modify promptInstall to always use the non-webstore option if this feature is enabled. Then, modify the listener chrome.downloads.onChanged.addListener in background.js to use your new download method (or do nothing) if this feature is enabled. Finally, you would need to modify the Edge section of inject.js (line 152) to use promptInstall as well.

I can make the above changes myself if you prefer, but first I want to get a working ManifestV3 version of this extension, then I'll merge this PR.

@NeverDecaf NeverDecaf merged commit d89a7a4 into NeverDecaf:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants