Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

Update Config For Personas #51

Merged
merged 2 commits into from
May 2, 2019
Merged

Update Config For Personas #51

merged 2 commits into from
May 2, 2019

Conversation

richarddubay
Copy link
Member

DESCRIPTION

What does this PR do, or why is it needed?

This PR updates the config.yml file with the id of the app personas data view category.

How do I test this PR?

We'll know if it starts pulling content that's marked for you ... once we have content tagged.


I am affirming this is my best work (Ecclesiastes 9:10)

TODO

  • PR has a relevant title that will be understandable in a public changelog (ie...non developers)
  • [n/a] Closes DEV-XXX
  • No new warnings in tests, in storybook, and in-app
  • Upload GIF(s) of iOS and Android if applicable
  • Set two relevant reviewers

REVIEW

Manual QA

  • Manual QA on iOS and ensure it looks/behaves as expected
  • Manual QA on Android and ensure it looks/behaves as expected

Code Review: Questions to consider

  • Read through the "Files changed" tab very carefully
  • Edge cases: what assumptions are made about input?
  • What kind of tests could be written?
  • How might we make this easier for someone else to understand?
  • Could the code be simpler?
  • Will the code be easy to modify in the future?
  • What's one part of these changes that makes you excited to merge it?

The purpose of PR Review is to improve the quality of the software.

@codecov-io
Copy link

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   56.43%   56.43%           
=======================================
  Files         150      150           
  Lines        1701     1701           
  Branches      180      180           
=======================================
  Hits          960      960           
  Misses        660      660           
  Partials       81       81

@IsaacHardy IsaacHardy added merge When the tests pass, merge! and removed ready for review This is ready to be reviewd labels May 2, 2019
@IsaacHardy IsaacHardy merged commit 22dec4f into master May 2, 2019
@richarddubay richarddubay deleted the update-config branch July 2, 2019 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge When the tests pass, merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants