This repository has been archived by the owner on Jan 14, 2020. It is now read-only.
Setup Location resolvers to work with NewSpring Specific data #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
- Coverage 56.37% 56.18% -0.2%
=========================================
Files 150 150
Lines 1717 1723 +6
Branches 181 185 +4
=========================================
Hits 968 968
- Misses 668 670 +2
- Partials 81 85 +4
|
|
This is pulling campuses that should be closed. It's also pulling 'Web' ... I'm pretty sure we shouldn't show that as a campus.
|
|
@richarddubay This PR's code is only to protect against null and undefined values. I believe the issue with bad data comes from Rock specific data. We should be able to do that from the admin panel. |
|
Okay, that's cool. I was worried that we were pulling campuses that should be closed ... and maybe that would need to be addressed here. But we can look to a later time for that. |
richarddubay
previously approved these changes
May 2, 2019
richarddubay
added
merge
|
@richarddubay I'm updating the createAssetUrl. Had a better idea for it. |
richarddubay
approved these changes
May 2, 2019
| if (value.path) { | ||
| return value.path; | ||
| } | ||
| if (value.Key && value.AssetStorageProviderId) { |
There was a problem hiding this comment.
Just covering :allthethings:. Nice.
richarddubay
added
merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
What does this PR do, or why is it needed?
We need to update resolvers to work with null or undefined data. This PR protects from that.
How do I test this PR?
Go through the on boarding process and make sure newspring campuses are available.
TODO
REVIEW
Manual QA
Code Review: Questions to consider