Make ext:registerAutoPackageIO defer its legacy registrations #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… requested. Also make AutoPackageIO.__class_init__ responsible for returning the legacy factory object instead of registering it itself.
This lets it detect conflicts. This also lets it be used with <registerIn> to localize them (yay). I did *not* add an escape hatch to make it register them eagerly still and ignore conflicts, but we can if that turns out to be necessary. Fixes #28
|
Merging this will also merge #38. I just want to make sure everybody's good with both sets of changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets it detect conflicts. This also lets it be used with
<registerIn>to localize them (yay).I did not add an escape hatch to make it register them eagerly still and ignore conflicts, but we can if that turns out to be necessary.
Fixes #28
Currently based on #38