-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pep8, pyflakes, unit and integration tests to setup.py #26
Conversation
Creates a static mapping of possible commands to their actual package+class names. This is more explicit, and cleans up some pyflakes warnings about unused imports. Also add pyflakes to the TravisCI tests.
The pep8/pyflakes requirements are put into requirements.test.txt in https://github.com/diranged/ndserviceregistry/commit/2a6772d9eae5054772f4015f75f5782fc3257fbd |
No need to do the 'i for i in ...' code since readlines() already returns a list.
looks good to me. |
…xt files in the final package.
Last bugfix.. this fixes the final package so its actually installable.
|
@@ -90,7 +90,7 @@ def decode(data): | |||
elif s.startswith('{') and s.endswith('}'): | |||
try: | |||
data = json.loads(s) | |||
except Exception, e: | |||
except Exception: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little wary when I see statement like except Exception:
We should be more specific on what exception to accept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke to Matt about this. He is going to insert the TODO to work on that on later days.
Once that's done, this change is approved.
Add pep8, pyflakes, unit and integration tests to setup.py (Approved by @dfujiwara)
Bump nd_service_registry to 0.3.0a1. Adds the following cleanup items:
setup.py