cd setting build #126
Merged
cd setting build #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* uiState 변경 방식 update 로 통일 * TODO 제거 이거 예전에 지웠는데 왜 남아있지 * Ktor 를 Retrofit 으로 migration * GuestLogin 관련 함수를 BandalartService 내에서 분리 GuestLoginService interface 로 따로 선언 * style check success * 사용하지 않는 클래스 주석처리 * GuestLoginService Provider 추가 * KtorClient, RetrofitClient 를 별도의 networkModule 로 분리 networkModule 을 생성함에 따라 모듈의 순환 구조를 방지하기 위해 datastore 모듈 추가 * style check success * style check success * fix run build fail * 스플래시 뷰모델 api 호출 이후 0.5 초 이내에 응답을 받을 경우 Loading Screen 을 띄우지 않는 로직 적용 update 로 uiState 변경 로직 통일 * chore: 코드 정리 viewModel 에서 수집한 error 는 이미 toAlertMessage 함수에 의해 custom 된 exception message 이므로 로그를 확인할 필요가 없으므로 제거 * 하드코딩된 텍스트 stringResource 로 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.