다국어 지원 완료 #150
Merged
다국어 지원 완료 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO 추가
…tilingual-support # Conflicts: # core/ui/src/main/kotlin/com/nexters/bandalart/android/core/ui/component/AppTitle.kt # feature/home/src/main/kotlin/com/nexters/bandalart/android/feature/home/BandalartBottomSheet.kt
영어일 경우 title을 24자 까지 허용, description 은 1000자 까지 허용
뷰에 실질적으로 영향을 끼치지 않으므로, 필요하지 않음
TODO 각 셀의 title 을 삭제 다이얼로그의 title 에 포함 시켜야 함
TODO Lottie 도 분기 처리 해야 함
easyhooon
added
feature
likppi10
approved these changes
Dec 22, 2023
| @@ -12,7 +12,7 @@ import org.gradle.kotlin.dsl.configure | |||
| import org.gradle.kotlin.dsl.getByType | |||
| import org.jetbrains.kotlin.gradle.dsl.KotlinProjectExtension | |||
|
|
|||
| internal fun Project.configureAndroid(extension: CommonExtension<*, *, *, *>) { | |||
| internal fun Project.configureAndroid(extension: CommonExtension<*, *, *, *, *>) { | |||
There was a problem hiding this comment.
저기에 * 하나 더 달리는거는 무슨 차이야?
저런게 바꼈다는거는 어디서 볼 수 있어?
There was a problem hiding this comment.
저기에 * 하나 더 달리는거는 무슨 차이야?
저런게 바꼈다는거는 어디서 볼 수 있어?
agp 버전 업데이트하는데 Star-projection 개수 관련한 에러가 발생해서 검색했었는데 8.0.2 -> 8.1.1 로 넘어갈때 그 개수가 4개에서 5개로 늘었더라고 그래서 하나 더 붙혀줬어
https://stackoverflow.com/questions/77036477/build-failure-after-migrating-to-gradle-8-1-1
| @@ -37,13 +35,13 @@ fun BandalartButton( | |||
| .padding(16.dp), | |||
| contentAlignment = Alignment.Center, | |||
| ) { | |||
| Text( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
앱 네이밍 다국어 지원
온보딩 다국어 지원(lottie 제외)
삭제 다이얼로그에 삭제할 cell 의 title을 포함(피그마 디자인 반영)
테스크 삭제 다이얼로그 message 제거(피그마 디자인 반영)
뷰모델 에서만 사용되는 error 파라미터 제거
공유하기 텍스트 다국어 지원
컴포즈 성능 최적화 (Painter API -> ImageVector 로 변경)
누락된 FIxedSizeText 적용