Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

다국어 지원 완료 #150

Merged
merged 18 commits into from
Dec 22, 2023
Merged

Conversation

easyhooon
Copy link
Collaborator

  • 앱 네이밍 다국어 지원

  • 온보딩 다국어 지원(lottie 제외)

  • 삭제 다이얼로그에 삭제할 cell 의 title을 포함(피그마 디자인 반영)

  • 테스크 삭제 다이얼로그 message 제거(피그마 디자인 반영)

  • 뷰모델 에서만 사용되는 error 파라미터 제거

  • 공유하기 텍스트 다국어 지원

  • 컴포즈 성능 최적화 (Painter API -> ImageVector 로 변경)

  • 누락된 FIxedSizeText 적용

…tilingual-support

# Conflicts:
#	core/ui/src/main/kotlin/com/nexters/bandalart/android/core/ui/component/AppTitle.kt
#	feature/home/src/main/kotlin/com/nexters/bandalart/android/feature/home/BandalartBottomSheet.kt
영어일 경우 title을 24자 까지 허용,
description 은 1000자 까지 허용
뷰에 실질적으로 영향을 끼치지 않으므로, 필요하지 않음
TODO 각 셀의 title 을 삭제 다이얼로그의 title 에 포함 시켜야 함
TODO Lottie 도 분기 처리 해야 함
@easyhooon easyhooon self-assigned this Dec 22, 2023
@easyhooon easyhooon added feature tasks related to feature development design tasks related to design aspects of the project refactoring Code restructure for better readability and efficiency labels Dec 22, 2023
Copy link
Collaborator

@likppi10 likppi10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많았서!

@@ -12,7 +12,7 @@ import org.gradle.kotlin.dsl.configure
import org.gradle.kotlin.dsl.getByType
import org.jetbrains.kotlin.gradle.dsl.KotlinProjectExtension

internal fun Project.configureAndroid(extension: CommonExtension<*, *, *, *>) {
internal fun Project.configureAndroid(extension: CommonExtension<*, *, *, *, *>) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저기에 * 하나 더 달리는거는 무슨 차이야?
저런게 바꼈다는거는 어디서 볼 수 있어?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저기에 * 하나 더 달리는거는 무슨 차이야?
저런게 바꼈다는거는 어디서 볼 수 있어?

agp 버전 업데이트하는데 Star-projection 개수 관련한 에러가 발생해서 검색했었는데 8.0.2 -> 8.1.1 로 넘어갈때 그 개수가 4개에서 5개로 늘었더라고 그래서 하나 더 붙혀줬어

https://stackoverflow.com/questions/77036477/build-failure-after-migrating-to-gradle-8-1-1

https://android.googlesource.com/platform/tools/base/+/655ea2cf3bd8337a8a2172446a4c4713040d7df0%5E%21/

@@ -37,13 +35,13 @@ fun BandalartButton(
.padding(16.dp),
contentAlignment = Alignment.Center,
) {
Text(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼해 꼼꼼해 👍

@easyhooon easyhooon merged commit 582fc9f into develop Dec 22, 2023
1 check passed
@easyhooon easyhooon deleted the feature/finish-multilingual-support branch December 22, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design tasks related to design aspects of the project feature tasks related to feature development refactoring Code restructure for better readability and efficiency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants