-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
다국어 지원 완료 #150
Merged
Merged
다국어 지원 완료 #150
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bd632a0
스플래시 화면 다국어 지원 적용
easyhooon f92843e
string resource 개행 추가
easyhooon 50bc1b6
deprecated 된 icon 수정
easyhooon 10324c6
Merge remote-tracking branch 'origin/develop' into feature/finish-mul…
easyhooon 30c3296
merge 과정 중 util로 이동된 import 반영
easyhooon 1f5772d
누락된 공유하기 텍스트 다국어 지원 및 텍스트 수정
easyhooon 534180b
build.gradle version update
easyhooon 9f0d23b
누락된 FixedSizeText 적용
easyhooon 23c8e85
셀의 title, description 글자 수 제한 수정
easyhooon 8768336
뷰모델 내에서만 사용되는 error 상태 변수 제거
easyhooon 23ff439
테스크 삭제 다이얼로그 피그마 디자인에 따라 message 를 공백으로 변경
easyhooon ef362d1
반다라트 삭제 다이얼로그 다국어 지원 임시 대응
easyhooon 0e644e6
각 셀의 title 을 삭제 다이얼로그의 title 에 포함
easyhooon e021a27
Painter API ImageVector 로 변경
easyhooon 757357e
OnBoarding 다국어 지원 분기 처리
easyhooon 2ef562b
온보딩 lottie 다국어 지원 분기 처리 준비
easyhooon bb74d45
AppName 다국어 처리
easyhooon c9f9d49
style check success
easyhooon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,12 @@ | ||
<vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:width="108dp" | ||
android:height="108dp" | ||
android:viewportWidth="192" | ||
android:viewportHeight="192"> | ||
<group android:scaleX="0.67" | ||
android:scaleY="0.67" | ||
android:translateX="31.68" | ||
android:translateY="31.68"> | ||
<path | ||
android:pathData="M0,0h192v192h-192z" | ||
android:fillColor="#f9fafb"/> | ||
<path | ||
android:pathData="M39,40C39,33.37 44.37,28 51,28L123.37,28C134.01,28 139.38,40.83 131.92,48.41L95.72,85.22L59.49,121.49C51.93,129.06 39,123.7 39,113.01L39,40Z" | ||
android:fillColor="#f9fafb"/> | ||
<path | ||
android:pathData="M152,151C152,157.63 146.63,163 140,163L67.63,163C56.99,163 51.61,150.17 59.08,142.59L95.28,105.78L131.51,69.51C139.07,61.94 152,67.3 152,77.99L152,151Z" | ||
android:fillColor="#f9fafb"/> | ||
</group> | ||
android:width="28dp" | ||
android:height="34dp" | ||
android:viewportWidth="28" | ||
android:viewportHeight="34"> | ||
<path | ||
android:pathData="M0,2.973C0,1.331 1.331,0 2.973,0L20.905,0C23.542,0 24.874,3.178 23.025,5.058L14.055,14.179L5.077,23.166C3.204,25.04 0,23.714 0,21.064L0,2.973Z" | ||
android:fillColor="#3FFFBA"/> | ||
<path | ||
android:pathData="M28,30.478C28,32.12 26.669,33.451 25.027,33.451L7.095,33.451C4.458,33.451 3.126,30.273 4.975,28.393L13.945,19.272L22.923,10.285C24.796,8.411 28,9.737 28,12.387L28,30.478Z" | ||
android:fillColor="#111827"/> | ||
</vector> |
20 changes: 20 additions & 0 deletions
20
core/designsystem/src/main/res/drawable/ic_dummy_splash.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
<vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:width="108dp" | ||
android:height="108dp" | ||
android:viewportWidth="192" | ||
android:viewportHeight="192"> | ||
<group android:scaleX="0.67" | ||
android:scaleY="0.67" | ||
android:translateX="31.68" | ||
android:translateY="31.68"> | ||
<path | ||
android:pathData="M0,0h192v192h-192z" | ||
android:fillColor="#f9fafb"/> | ||
<path | ||
android:pathData="M39,40C39,33.37 44.37,28 51,28L123.37,28C134.01,28 139.38,40.83 131.92,48.41L95.72,85.22L59.49,121.49C51.93,129.06 39,123.7 39,113.01L39,40Z" | ||
android:fillColor="#f9fafb"/> | ||
<path | ||
android:pathData="M152,151C152,157.63 146.63,163 140,163L67.63,163C56.99,163 51.61,150.17 59.08,142.59L95.28,105.78L131.51,69.51C139.07,61.94 152,67.3 152,77.99L152,151Z" | ||
android:fillColor="#f9fafb"/> | ||
</group> | ||
</vector> |
496 changes: 496 additions & 0 deletions
496
core/designsystem/src/main/res/drawable/ic_onboarding_en.xml
Large diffs are not rendered by default.
Oops, something went wrong.
File renamed without changes.
Large diffs are not rendered by default.
Oops, something went wrong.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,19 +6,17 @@ import androidx.compose.foundation.layout.fillMaxWidth | |
import androidx.compose.foundation.layout.height | ||
import androidx.compose.foundation.layout.padding | ||
import androidx.compose.foundation.shape.RoundedCornerShape | ||
import androidx.compose.material3.Text | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.ui.Alignment | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.draw.clip | ||
import androidx.compose.ui.text.font.FontWeight | ||
import androidx.compose.ui.unit.dp | ||
import androidx.compose.ui.unit.sp | ||
import com.nexters.bandalart.android.core.ui.extension.clickableSingle | ||
import com.nexters.bandalart.android.core.ui.nonScaleSp | ||
import com.nexters.bandalart.android.core.designsystem.theme.Gray900 | ||
import com.nexters.bandalart.android.core.designsystem.theme.White | ||
import com.nexters.bandalart.android.core.designsystem.theme.pretendard | ||
import com.nexters.bandalart.android.core.ui.extension.clickableSingle | ||
|
||
@Composable | ||
fun BandalartButton( | ||
|
@@ -37,13 +35,13 @@ fun BandalartButton( | |
.padding(16.dp), | ||
contentAlignment = Alignment.Center, | ||
) { | ||
Text( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 꼼꼼해 꼼꼼해 👍 |
||
FixedSizeText( | ||
text = text, | ||
fontFamily = pretendard, | ||
fontWeight = FontWeight.W700, | ||
fontSize = 16.sp.nonScaleSp, | ||
fontSize = 16.sp, | ||
color = White, | ||
letterSpacing = (-0.32).sp.nonScaleSp, | ||
letterSpacing = (-0.32).sp, | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저기에 * 하나 더 달리는거는 무슨 차이야?
저런게 바꼈다는거는 어디서 볼 수 있어?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agp 버전 업데이트하는데 Star-projection 개수 관련한 에러가 발생해서 검색했었는데 8.0.2 -> 8.1.1 로 넘어갈때 그 개수가 4개에서 5개로 늘었더라고 그래서 하나 더 붙혀줬어
https://stackoverflow.com/questions/77036477/build-failure-after-migrating-to-gradle-8-1-1
https://android.googlesource.com/platform/tools/base/+/655ea2cf3bd8337a8a2172446a4c4713040d7df0%5E%21/