Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/42 환불 요청 #105

Merged
merged 8 commits into from
Feb 14, 2024
Merged

Feature/42 환불 요청 #105

merged 8 commits into from
Feb 14, 2024

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Feb 13, 2024

Issue

작업 내용

  • 텍스트 필드 유효성 검사
  • 환불 api 호출
KakaoTalk_20240214_032903601.mp4

코멘트

  • 싱싱미역 상태라 녹화시 계좌번호란에 전화번호를 적었지만 정상 동작합니다...
  • error 일 때 border가 focus 되면 두꺼워지는데, 해결 방법을 찾을 기력이 없습니다...
  • TextField에 supporting text를 이용하면 더 좋은 해결 방법이 되겠으나, 나중에 리팩 하겠습니다. 사실 시도해봤으나 텍스트 컬러랑 이상한 패딩이 들어가 있어서 해결하진 않고 일단 뺐습니다.

@HamBP HamBP requested a review from mangbaam February 13, 2024 18:30
@HamBP HamBP self-assigned this Feb 13, 2024
@HamBP HamBP added the feat 새로운 기능 label Feb 13, 2024
@HamBP HamBP added this to the my page milestone Feb 13, 2024
@HamBP HamBP changed the title Feature/42 Feature/42 환불 요청 Feb 13, 2024
Copy link
Member

@mangbaam mangbaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

보더 색상 칠해지는 건 어색하진 않은 거 같아

Comment on lines +13 to +21
val isValidName: Boolean get() {
val regex = "^[가-힣]{2,10}$".toRegex()
return regex.matches(name)
}

val isValidContact: Boolean get() {
val regex = "^0[0-9]{8,10}$".toRegex()
return regex.matches(contact)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 정규식들은 아직 다른 파트랑 맞춰진 건 아니지?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엉 맞춰진 건 아니라서 내가 생각했을 때 널널하게 정해놨어

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 얘기해서 맞추는 게 좋을 듯!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내 메모장에 적어둘게!

@HamBP HamBP merged commit a5d04ab into develop Feb 14, 2024
@HamBP HamBP deleted the feature/42 branch February 14, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능
Projects
None yet
Development

Successfully merging this pull request may close these issues.

환불 요청 기능 구현
2 participants