feat/256 : 결제 내역에 선물 케이스 추가 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 9 files 9 suites 0s ⏱️ Results for commit 8781c6a. ♻️ This comment has been updated with latest results. |
mangbaam
approved these changes
Jul 27, 2024
data/src/main/java/com/nexters/boolti/data/network/response/ReservationDetailResponse.kt
Show resolved
Hide resolved
...entation/src/main/java/com/nexters/boolti/presentation/reservationdetail/ResendGiftButton.kt
Show resolved
Hide resolved
...n/src/main/java/com/nexters/boolti/presentation/reservationdetail/ReservationDetailScreen.kt
Outdated
Show resolved
Hide resolved
| private val reservationId: String = checkNotNull(savedStateHandle["reservationId"]) { | ||
| "reservationId가 전달되어야 합니다." | ||
| private val id: String = checkNotNull(savedStateHandle["reservationId"]) { | ||
| "id가 전달되어야 합니다." |
There was a problem hiding this comment.
[의견]
실제로 사용하는 아규먼트 키는 reservationId 라서 디버깅할 땐 reservationId가 더 명확할 듯
There was a problem hiding this comment.
일반 예매인 경우 API에 reservationId를, 선물인 경우 API에 giftId 를 넘겨 주어야 해서, 일반적인 네이밍인 id로 변경했었어. 그래서 사실 argument key도 같이 바꿨어야 했는데, key값은 하드코딩 + 수정할 곳이 많아서 변수명만 바꿨던 것...
일단 reservationId로 다시 변경할게
There was a problem hiding this comment.
아하 reservationId랑 giftId는 같은 역할인거야?
There was a problem hiding this comment.
맞아
결제 내역 목록에서는 예매 내역이랑 선물 내역이 하나의 api로 호출되는데, 상세로 넘어갈 때는 api가 분리 돼서 조금 까다로워졌어
presentation/src/main/java/com/nexters/boolti/presentation/screen/refund/RefundNavigation.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
작업 내용
코멘트
KakaoTalk_20240724_234545521.mp4