fix(cookie): cookie 생성 시 domain 추가 (#36)

Nexters · Aug 4, 2020 · 3e24ccb · 3e24ccb
1 parent c604aa1
commit 3e24ccb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/apps/oauth/client.py b/src/apps/oauth/client.py
@@ -73,5 +73,7 @@ async def sign_in(
         session.commit()
     app_token = create_access_token(google_user_info)
     response = RedirectResponse(url=settings.WEB_URI)
-    response.set_cookie(key="token", value=app_token)
+    response.set_cookie(
+        key="token", value=app_token, domain=settings.WEB_URI.host
+    )
     return response
diff --git a/src/core/config.py b/src/core/config.py
@@ -34,7 +34,7 @@ class Settings(BaseSettings):
     PUBLIC_KEY: str = ""
     JWT_ALGORITHM: str = "RS256"
     SECRET_KEY: str = ""
-    WEB_URI: str = "https://checkhaebang.com/"
+    WEB_URI: HttpUrl = "https://checkhaebang.com"  # type: ignore
     CORS_ALLOWS: List[HttpUrl] = []
 
     ACCESS_TOKEN_EXPIRE_SECONDS: int = 86400 * 7