Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tenderly simulation to setProducts script #1132

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

rackstar
Copy link
Contributor

@rackstar rackstar commented Jun 13, 2024

Context

Add tenderly simulation to setProducts script.

Product listing docs have been updated accordingly

Changes proposed in this pull request

  • Add tenderly simulation to setProducts script

Test plan

  • manual test

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@rackstar rackstar self-assigned this Jun 13, 2024
@rackstar rackstar force-pushed the fix/set-products-script-metadata-path branch from 9bb943f to 9c4f4c1 Compare June 13, 2024 19:19
@rackstar rackstar changed the title feat: Add tenderly simulation to setProducts script DRAFT feat: Add tenderly simulation to setProducts script Jun 17, 2024
@rackstar
Copy link
Contributor Author

marking as DRAFT for now until I add a validation script to compare the tenderly decoded tx input to the CSV data

@roxdanila roxdanila added chore and removed feature labels Jun 17, 2024
@roxdanila roxdanila marked this pull request as draft June 17, 2024 13:53
@rackstar rackstar changed the title DRAFT feat: Add tenderly simulation to setProducts script feat: Add tenderly simulation to setProducts script Jun 17, 2024
@rackstar rackstar marked this pull request as ready for review June 17, 2024 17:59
@rackstar rackstar force-pushed the fix/set-products-script-metadata-path branch 5 times, most recently from c2a1501 to 249e147 Compare June 18, 2024 08:07
@rackstar rackstar force-pushed the fix/set-products-script-metadata-path branch from 249e147 to af10559 Compare June 18, 2024 08:20
@roxdanila roxdanila merged commit f30307f into release-candidate Jun 18, 2024
6 checks passed
@roxdanila roxdanila deleted the fix/set-products-script-metadata-path branch June 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants