Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Remove pool 8 bug fix #1154

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Chore: Remove pool 8 bug fix #1154

merged 1 commit into from
Jun 28, 2024

Conversation

MilGard91
Copy link
Contributor

Context

Issue: #1153

Changes proposed in this pull request

  • Remove hot fix for pool 8

Test plan

N/A

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@MilGard91 MilGard91 requested a review from shark0der June 27, 2024 07:39
@MilGard91 MilGard91 linked an issue Jun 27, 2024 that may be closed by this pull request
chore: remove Pool 8 check in the processExpirations #1153
Closed
@shark0der shark0der changed the base branch from feature/cover-products-contract-rebased to release-candidate June 28, 2024 08:53
@shark0der shark0der changed the title chore: Remove pool 8 bug fix Chore: Remove pool 8 bug fix Jun 28, 2024
@shark0der shark0der force-pushed the chore/staking-pool-8-cleanup branch from 65f9aea to 1a39abc Compare June 28, 2024 08:54
@shark0der shark0der merged commit 2500ff1 into release-candidate Jun 28, 2024
4 checks passed
@shark0der shark0der deleted the chore/staking-pool-8-cleanup branch June 28, 2024 09:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shark0der shark0der shark0der approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: remove Pool 8 check in the processExpirations
2 participants
@MilGard91 @shark0der