Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: V2 migration fork test storage slots #640

Merged
merged 7 commits into from
Mar 6, 2023
Merged

Migration: V2 migration fork test storage slots #640

merged 7 commits into from
Mar 6, 2023

Conversation

MilGard91
Copy link
Contributor

@MilGard91 MilGard91 commented Jan 19, 2023 •
edited
Loading

Context

Closing: #609

Changes proposed in this pull request

Extracting Storage Layout from artifacts and using them to check the values on contracts using getStorageAt function before and after upgrade.

Test plan

Fork test expanded with storage tests.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@MilGard91 MilGard91 linked an issue Jan 19, 2023 that may be closed by this pull request
Fork test: assert storage slots on newly deployed contracts to check for storage corruption #609
Closed
@MilGard91 MilGard91 force-pushed the test/v2-migration-fork-test-storage-slots branch 2 times, most recently from 917446f to 49c1fc4 Compare January 19, 2023 14:42
@MilGard91 MilGard91 force-pushed the test/v2-migration-fork-test-storage-slots branch 5 times, most recently from a38b2f0 to 8af791d Compare January 23, 2023 11:33
@MilGard91 MilGard91 changed the base branch from feature/v2-migration-fork-test to nexus-v2 January 23, 2023 11:34
@MilGard91 MilGard91 force-pushed the test/v2-migration-fork-test-storage-slots branch from 8af791d to 7227316 Compare January 23, 2023 11:39
@MilGard91 MilGard91 marked this pull request as ready for review January 23, 2023 11:40
@shark0der shark0der force-pushed the test/v2-migration-fork-test-storage-slots branch from 7227316 to a7df05e Compare January 24, 2023 17:41
@roxdanila roxdanila force-pushed the test/v2-migration-fork-test-storage-slots branch from a7df05e to c3679c5 Compare January 26, 2023 12:50
@MilGard91 MilGard91 force-pushed the test/v2-migration-fork-test-storage-slots branch 5 times, most recently from 0ce1b15 to 1b3ce98 Compare January 26, 2023 15:03
@MilGard91 MilGard91 linked an issue Jan 26, 2023 that may be closed by this pull request
Fix: There is discrepancy in Pool data between V1 and V2 #643
Closed
@roxdanila roxdanila force-pushed the test/v2-migration-fork-test-storage-slots branch from 1b3ce98 to 9142b1c Compare January 30, 2023 10:30
@MilGard91 MilGard91 force-pushed the test/v2-migration-fork-test-storage-slots branch from 9142b1c to 9510edb Compare January 30, 2023 14:47
@MilGard91 MilGard91 force-pushed the test/v2-migration-fork-test-storage-slots branch 2 times, most recently from c66a7ca to 3ac2900 Compare February 27, 2023 07:51
@danoctavian
Copy link
Contributor

@MilGard91 still needs a lint fix

@roxdanila roxdanila force-pushed the test/v2-migration-fork-test-storage-slots branch 2 times, most recently from b6d8a7f to df03b3f Compare March 1, 2023 09:35
@shark0der
Copy link
Contributor

To be merged only after fix/migration-v2-stakingpool-pricing-asserts is merged #691

@shark0der shark0der force-pushed the test/v2-migration-fork-test-storage-slots branch 4 times, most recently from d985752 to 9a1d86f Compare March 3, 2023 19:03
This was referenced Mar 3, 2023
Closed
Merged
@shark0der shark0der force-pushed the test/v2-migration-fork-test-storage-slots branch from d71457a to 5e00b3c Compare March 3, 2023 19:08
danoctavian
danoctavian approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@danoctavian danoctavian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

We've been inspecting manually the results of the layout verifications throughout so we have the knowledge that it shows when things are off

@shark0der shark0der force-pushed the test/v2-migration-fork-test-storage-slots branch from 5e00b3c to 17d9af2 Compare March 6, 2023 11:21
@roxdanila roxdanila merged commit 4c9e4cf into nexus-v2 Mar 6, 2023
@roxdanila roxdanila deleted the test/v2-migration-fork-test-storage-slots branch March 6, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shark0der shark0der shark0der approved these changes

@danoctavian danoctavian danoctavian approved these changes

Assignees

@shark0der shark0der

Labels
migration
Projects
Engineering Tracker 💻
Archived in project
Milestone
No milestone
4 participants
@MilGard91 @danoctavian @shark0der @roxdanila