Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tokenomics ramm swap integration tests #949

Merged

Conversation

rackstar
Copy link
Contributor

@rackstar rackstar commented Oct 13, 2023

Context

Add RAMM integration tests.

Changes proposed in this pull request

  • add RAMM contract to integration/setup.js
  • add RAMM swap integration tests

Test plan

Please describe the tests cases that you ran to verify your changes. Add further instructions on
how to run them if needed (i.e. migration / deployment scripts, env vars, etc).

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@rackstar rackstar self-assigned this Oct 13, 2023
@rackstar rackstar changed the base branch from release-candidate to feature/tokenomics October 13, 2023 17:37
@rackstar rackstar mentioned this pull request Oct 13, 2023
9 tasks
@rackstar rackstar force-pushed the feature/tokenomics-ramm-swap-integration-tests branch from 178322f to cee36d5 Compare October 16, 2023 11:50
@rackstar rackstar linked an issue Oct 16, 2023 that may be closed by this pull request
@rackstar rackstar force-pushed the feature/tokenomics-ramm-swap-integration-tests branch from cee36d5 to c1c9685 Compare October 16, 2023 13:00
.eslintrc Show resolved Hide resolved
@rackstar rackstar force-pushed the feature/tokenomics-ramm-swap-integration-tests branch from c1c9685 to 191e808 Compare October 16, 2023 13:18
@rackstar rackstar linked an issue Oct 17, 2023 that may be closed by this pull request
12 tasks
@rackstar rackstar force-pushed the feature/tokenomics-ramm-swap-integration-tests branch from cb9b1a7 to c258e3d Compare October 17, 2023 09:17
@rackstar rackstar added the test label Oct 17, 2023
@rackstar rackstar force-pushed the feature/tokenomics-ramm-swap-integration-tests branch 6 times, most recently from b544d80 to 79eaa01 Compare October 18, 2023 09:04
@shark0der shark0der force-pushed the feature/tokenomics-ramm-swap-integration-tests branch from 79eaa01 to 333e8c9 Compare October 18, 2023 10:14
@rackstar rackstar merged commit 656c88e into feature/tokenomics Oct 18, 2023
6 checks passed
@rackstar rackstar deleted the feature/tokenomics-ramm-swap-integration-tests branch October 18, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Tokenomics: Fix failing integration tests Tokenomics: RAMM Integrations Tests
3 participants