Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank for your awesome effort on this library. I'm using it to parse the ID3v2 tags for some international files, and encounter issues when some frame is encoded with utf16. In which case it doesn't work well.
Finally I figured out there where two issues:
\xbaN
, but what you got as input is:[186, 78]
. So you should not directly useString.fromCodePoints()
. Instead use the official lib utf.