[ReaderHighlight] Remove duplicated setting on NT devices (koreader#1…

…1750) Closes koreader#11747.
NiLuJe · May 11, 2024 · baab326 · baab326
1 parent 1398154
commit baab326
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/frontend/apps/reader/modules/readerhighlight.lua b/frontend/apps/reader/modules/readerhighlight.lua
@@ -589,11 +589,12 @@ Except when in two columns mode, where this is limited to showing only the previ
         end,
     })
 
-    -- long_press menu is under taps_and_gestures menu which is not available for non touch device
-    -- Clone long_press menu and change label making much meaning for non touch devices
+    -- long_press setting is under taps_and_gestures menu which is not available for non-touch devices
+    -- Clone long_press setting and change its label, making it much more meaningful for non-touch device users.
     if not Device:isTouchDevice() and Device:hasDPad() then
-        menu_items.selection_text = util.tableDeepCopy(menu_items.long_press)
-        menu_items.selection_text.text = _("Select on text")
+        menu_items.selection_text = menu_items.long_press
+        menu_items.selection_text.text = _("Selection on text")
+        menu_items.long_press = nil
     end
 
     -- main menu Search