Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: asset.Pair #1171

Merged
merged 12 commits into from
Feb 3, 2023
Merged

refactor: asset.Pair #1171

merged 12 commits into from
Feb 3, 2023

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Feb 2, 2023 •
edited
Loading

Description

  • Replaces common.AssetPair with asset.Pair.
  • Fixes broken mockgen directive on x/perp expected keepers.
  • Moved constant declarations to better locations.

Purpose

Better package naming according to Golang best practices, as well as more organization in the x/common module.

@k-yang k-yang requested a review from a team as a code owner February 2, 2023 19:29
@k-yang k-yang enabled auto-merge (squash) February 2, 2023 19:29
@k-yang k-yang self-assigned this Feb 2, 2023
@k-yang k-yang added the refactor label Feb 2, 2023
@k-yang k-yang merged commit aa1bc51 into master Feb 3, 2023
@k-yang k-yang deleted the refactor/asset/pair branch February 3, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unique-Divine Unique-Divine Unique-Divine approved these changes

Assignees

@k-yang k-yang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-yang @Unique-Divine