Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(oracle): proto type docs, (2) oracle spec clean-up, and (3) remove panic #1184

Merged
merged 6 commits into from
Feb 8, 2023
Merged

refactor(oracle): proto type docs, (2) oracle spec clean-up, and (3) remove panic #1184

merged 6 commits into from
Feb 8, 2023

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine commented Feb 8, 2023 •
edited
Loading

For the reviewer

The meaningful changes are:

  • x/oracle/README.md
  • proto/oracle/* (doc comments)
  • a small panic removal in the calcTwap function

Commit log

  • fix(contrib): small version change in protocgen.sh
  • docs(oracle): better documentation on x/oracle proto types
  • docs(oracle): Update spec events, params, etc. and move to new single-file format
  • refactor,docs: more refactors and docs + remove panic case

@Unique-Divine Unique-Divine requested a review from a team as a code owner February 8, 2023 00:11
@Unique-Divine Unique-Divine changed the title docs(oracle): more docs and oracle spec clean-up refactor(oracle): proto type docs, (2) oracle spec clean-up, and (3) remove panic Feb 8, 2023
@Unique-Divine Unique-Divine enabled auto-merge (squash) February 8, 2023 00:20
@Unique-Divine Unique-Divine merged commit 0ed0a3b into master Feb 8, 2023
@Unique-Divine Unique-Divine deleted the realu/oracle-docs branch February 8, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-yang k-yang k-yang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Unique-Divine @k-yang