feat: reduce gas fees when posting price #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unique-Divine
requested changes
Mar 15, 2023
app/antedecorators/fee/fixed_gas.go
Outdated
| ctx = ctx.WithGasMeter(types.NewFixedGasMeter(OracleMessageGas)) | ||
| } else if hasOraclePreVoteMsg || hasOracleVoteMsg { | ||
| if len(tx.GetMsgs()) > 1 { | ||
| return ctx, sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "a transaction that includes an oracle vote or prevote message cannot have more than a single message") |
There was a problem hiding this comment.
Suggested change
| return ctx, sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "a transaction that includes an oracle vote or prevote message cannot have more than a single message") | |
| return ctx, sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "a transaction that includes an oracle vote or prevote message cannot have more than those two messages") |
k-yang
approved these changes
Mar 15, 2023
…biru into feat/fee-fixed-price-post
Unique-Divine
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes that transactions that include a vote or prevote to provide oracle prices is cheaper. Also it enforces that these kind of transactions can only hold one message, so it does no include a message unrelated to provide price data.
Purpose
This is important because right now posting a price is expensive and it does not scale well.