Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove panics from abci hooks #1423

Merged
merged 6 commits into from
Jun 14, 2023
Merged

fix: remove panics from abci hooks #1423

merged 6 commits into from
Jun 14, 2023

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Jun 12, 2023

Description

  • removes panics from abci hooks

Purpose

#1376

@k-yang k-yang self-assigned this Jun 12, 2023
@k-yang k-yang marked this pull request as ready for review June 12, 2023 19:57
@k-yang k-yang requested a review from a team as a code owner June 12, 2023 19:57
@k-yang k-yang enabled auto-merge (squash) June 12, 2023 19:57
@k-yang k-yang added this to the Audit milestone Jun 12, 2023
@k-yang k-yang linked an issue Jun 12, 2023 that may be closed by this pull request
[AUDIT] Remove panics from endblock/beginblock/afterepochend #1376
Closed
matthiasmatt
matthiasmatt reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@matthiasmatt matthiasmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's 2 panics in abci.go BeginBlocker from events, we might want to remove them as well just to be sure

@k-yang k-yang requested a review from matthiasmatt June 14, 2023 20:30
@k-yang k-yang merged commit 73d9bfd into master Jun 14, 2023
14 checks passed
@k-yang k-yang deleted the fix/remove-panics branch June 14, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasmatt matthiasmatt matthiasmatt approved these changes

Assignees

@k-yang k-yang

Labels
None yet
Projects
None yet
Milestone
Audit
Development

Successfully merging this pull request may close these issues.

[AUDIT] Remove panics from endblock/beginblock/afterepochend
2 participants
@k-yang @matthiasmatt