Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(perp)!: rename OpenPosition to MarketOrder #1473

Merged
merged 7 commits into from
Jul 1, 2023
Merged

refactor(perp)!: rename OpenPosition to MarketOrder #1473

merged 7 commits into from
Jul 1, 2023

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Jul 1, 2023 •
edited by Unique-Divine
Loading

Description

  • renames OpenPosition to MarketOrder
  • uploads newly compiled bindings-perp with new market_position struct
  • no test logic was updated

Relies on:

Purpose

Meaningful Names

@k-yang k-yang marked this pull request as ready for review July 1, 2023 19:23
@k-yang k-yang requested a review from a team as a code owner July 1, 2023 19:23
@k-yang k-yang self-assigned this Jul 1, 2023
@k-yang k-yang linked an issue Jul 1, 2023 that may be closed by this pull request
refactor(perp)!: OpenPosition → MarketOrder #1472
Closed
@k-yang k-yang enabled auto-merge (squash) July 1, 2023 19:24
@Unique-Divine Unique-Divine added type: refactor dependencies Pull requests that update a dependency file and removed type: refactor labels Jul 1, 2023
@k-yang k-yang merged commit 9f6c5cf into master Jul 1, 2023
13 of 14 checks passed
@k-yang k-yang deleted the refactor/perp/open-position-to-market-order branch July 1, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unique-Divine Unique-Divine Unique-Divine approved these changes

Assignees

@k-yang k-yang

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(perp)!: OpenPosition → MarketOrder
2 participants
@k-yang @Unique-Divine