test(common): add docs for testutil and increase test coverage #1527

Unique-Divine · 2023-07-27T19:23:13Z

In `x/common`

test(common): document and test BankersRound
test(common): address utils test- docs(testutil/cli): documentation for the Network and Validator structs
refactor(testutil): Organize network files

In other modules

Fixes bug(amm.go): should we check over flow on the product of quote and base? #1524
refactor: DRY improvements for genesis cli tests

…tside the cosmos-sdk

…ests

commit dc5559c Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 20:46:27 2023 -0500 test(inflation): run the suite commit d526b2a Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 20:36:36 2023 -0500 linter commit 062dbfc Merge: 392d080 e793851 Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 20:25:22 2023 -0500 Merge branch 'realu/test-inflation' into realu/test-inflation-2 commit e793851 Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 20:10:32 2023 -0500 test(inflation): test getters in params.go commit 392d080 Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 19:21:07 2023 -0500 test(inflation): param set pairs commit 2aa65ed Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 19:01:00 2023 -0500 refactor(simapp): simapp fns are not used outside the simapp dir or tests commit 68c47ad Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 13:22:01 2023 -0500 refactor: remove unused fn commit 8a01ec1 Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 12:37:34 2023 -0500 small refactor for better var names commit d263ffb Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 12:07:56 2023 -0500 changelog commit aa92edd Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 12:06:51 2023 -0500 deps: remove usage of cosmossdk.io/depinject since it doesn't work outside the cosmos-sdk commit b774c48 Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 12:05:47 2023 -0500 refactor: make it possible to use the encoding config without the app commit 2e7192a Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 10:54:18 2023 -0500 linter commit 773dee4 Merge: efac0d8 0c571c6 Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 10:53:20 2023 -0500 Merge branch 'master' into realu/test-inflation commit efac0d8 Author: Unique-Divine <realuniquedivine@gmail.com> Date: Tue Jul 25 10:52:20 2023 -0500 feat(wasm): no op handler + tests with updated shifter.wasm commit 2ed7490 Author: Unique-Divine <realuniquedivine@gmail.com> Date: Mon Jul 24 15:45:12 2023 -0500 test(inflation): types coverage

… more obvious

codecov · 2023-07-27T19:34:53Z

Codecov Report

Merging #1527 (19a33bd) into master (b1477cd) will increase coverage by 2.49%.
Report is 3 commits behind head on master.
The diff coverage is 96.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
+ Coverage   67.44%   69.94%   +2.49%     
==========================================
  Files         162      163       +1     
  Lines       13967    13957      -10     
==========================================
+ Hits         9420     9762     +342     
+ Misses       3927     3554     -373     
- Partials      620      641      +21

Files Changed	Coverage Δ
x/common/dec.go	`74.13% <75.00%> (+48.21%)`	⬆️
x/common/testutil/cli/network.go	`74.05% <97.05%> (+14.27%)`	⬆️
x/common/testutil/cli/tx.go	`66.34% <97.22%> (+66.34%)`	⬆️
x/common/asset/pair.go	`80.45% <100.00%> (+34.30%)`	⬆️
x/common/testutil/cli/network_config.go	`100.00% <100.00%> (ø)`
x/common/testutil/cli/util.go	`72.16% <100.00%> (+15.78%)`	⬆️
x/perp/v2/types/amm.go	`87.78% <100.00%> (ø)`
x/spot/client/testutil/suite.go	`97.55% <100.00%> (ø)`

... and 6 files with indirect coverage changes

Unique-Divine · 2023-08-02T21:17:39Z

x/common/asset/pair.go

@@ -149,49 +149,19 @@ func (pairKeyEncoder) Decode(b []byte) (int, Pair) {
 	return i, MustNewPair(s)
 }

-//-----------------------------------------------------------------------------


Searched with the LSP and and found that this type alias was largely unused, so I removed some of the dead code.

Unique-Divine · 2023-08-02T21:19:41Z

x/common/dec.go

@@ -10,7 +10,7 @@ import (



Made the code more descriptive here and added tests for it. Since the Sqrt is used in x/perp, it's important to make sure these functions don't panic.

Unique-Divine · 2023-08-02T21:21:34Z

x/common/testutil/cli/logger.go

@@ -0,0 +1,16 @@
+package cli


Previously, the Network, Config (of the network), and Logger interface were all defined in one file, which made things hard to follow. I added documentation for parts that weren't obvious, separated these structs to their own files, added tests, and deleted code that was unused in integration tests.

Unique-Divine · 2023-08-02T21:57:28Z

x/common/testutil/cli/network_config.go

+
+// AbsorbListenAddresses ensures that the listening addresses for an active
+// node are set on the network config.
+func (cfg *Config) AbsorbListenAddresses(val *Validator) {


The listen addresses for RPC, GRPC, and API should be set on the Config but weren't by default. This made the API unintuitive when trying to grab the raw grpc.Conn objects or rpc.RPCClient.

Unique-Divine added 30 commits July 24, 2023 15:45

test(inflation): types coverage

2ed7490

feat(wasm): no op handler + tests with updated shifter.wasm

efac0d8

Merge branch 'master' into realu/test-inflation

773dee4

linter

2e7192a

refactor: make it possible to use the encoding config without the app

b774c48

deps: remove usage of cosmossdk.io/depinject since it doesn't work ou…

aa92edd

…tside the cosmos-sdk

changelog

d263ffb

small refactor for better var names

8a01ec1

refactor: remove unused fn

68c47ad

refactor(simapp): simapp fns are not used outside the simapp dir or t…

2aa65ed

…ests

test(inflation): param set pairs

392d080

test(inflation): test getters in params.go

e793851

Merge branch 'realu/test-inflation' into realu/test-inflation-2

062dbfc

linter

d526b2a

test(inflation): run the suite

dc5559c

test(common): EnsureNibiruPrefix

e4c1600

test(sudo): remove unused fns and increase coverage

c19917b

test(spot): wait another block for concurrency issue

bc33367

test(spot): wait another block for concurrency issue

743652a

test(inflation): cover last few grpc queries

4e550a0

Merge branch 'realu/test-inflation' into realu/test-sudo

378ace5

ci: add concurrency statements to workflows

7a47d59

Merge branch 'realu/test-inflation' into realu/test-sudo

53d2d16

test(perp/cli): use the same server between runs for gen_market_test

7780cc8

refactor: make registration aspect of the encoding config constructor…

253cb65

… more obvious

Merge branch 'master' into realu/test-inflation

eaefe17

(test.mk): add a test-coverage-integration command

2362461

Merge branch 'realu/test-inflation' into realu/test-sudo

85933c4

Merge branch 'realu/test-sudo' into realu/test-determinism

c7d0d26

Unique-Divine added 5 commits July 26, 2023 23:24

test(common): document and test BankersRound

3bf66d6

fix(amm.go): small bug in ComputeSqrtDepth

9659a54

docs(testutil/cli): documentation for the Network and Validator structs

182786c

Merge branch 'master' into realu/test-determinism

35f04f5

test(common): address utils test

bfb88d8

Unique-Divine changed the title ~~test(common): docs and tests~~ test(common): add docs for testutil and increase test coverage Jul 27, 2023

Unique-Divine added 9 commits July 27, 2023 14:44

changelog + linter

9395e79

test(common): remove unused code + more tests

0b5e87f

simplify the 'with' functions

0a56cd2

fix finicky tests

d7ea816

Merge branch 'master' into realu/test-determinism

582f274

test(testutil): remove unused code + add tests

cac831f

test(testutil): more tests + better var names

28191fe

refactor: ExecTx -> Network.ExecTxCmd

c313b59

Merge branch 'master' into realu/test-determinism

b0022cd

Unique-Divine marked this pull request as ready for review August 2, 2023 21:16

Unique-Divine requested a review from a team as a code owner August 2, 2023 21:16

Unique-Divine commented Aug 2, 2023

View reviewed changes

test,refactor: make getters to use in place of the 'PrintMnemonic' func

19a33bd

Unique-Divine commented Aug 2, 2023

View reviewed changes

Unique-Divine added type: fix/bug labels Aug 2, 2023

matthiasmatt approved these changes Aug 3, 2023

View reviewed changes

matthiasmatt merged commit ee53dae into master Aug 3, 2023
22 checks passed

matthiasmatt deleted the realu/test-determinism branch August 3, 2023 20:02

Unique-Divine mentioned this pull request Aug 9, 2023

epic: Some healthy mainnet QA focused on test coverage #1512

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(common): add docs for testutil and increase test coverage #1527

test(common): add docs for testutil and increase test coverage #1527

Unique-Divine commented Jul 27, 2023 •

edited

Loading

codecov bot commented Jul 27, 2023 •

edited

Loading

Unique-Divine Aug 2, 2023 •

edited

Loading

Unique-Divine Aug 2, 2023

Unique-Divine Aug 2, 2023

Unique-Divine Aug 2, 2023 •

edited

Loading

test(common): add docs for testutil and increase test coverage #1527

test(common): add docs for testutil and increase test coverage #1527

Conversation

Unique-Divine commented Jul 27, 2023 • edited Loading

In x/common

In other modules

codecov bot commented Jul 27, 2023 • edited Loading

Codecov Report

Unique-Divine Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

Unique-Divine Aug 2, 2023

Choose a reason for hiding this comment

Unique-Divine Aug 2, 2023

Choose a reason for hiding this comment

Unique-Divine Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

Unique-Divine commented Jul 27, 2023 •

edited

Loading

In `x/common`

codecov bot commented Jul 27, 2023 •

edited

Loading

Unique-Divine Aug 2, 2023 •

edited

Loading

Unique-Divine Aug 2, 2023 •

edited

Loading