-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tokenfactory): execute msgs for CreateDenom, ChangeAdmin, UpdateModuleParams #1607
Conversation
Unique-Divine
commented
Sep 28, 2023
•
edited
Loading
edited
- Includes queries, transaction messages, and CLI commands for CreateDenom, ChangeAdmin, and UpdateModuleParams
- Part of [epic] feat: "tokenfactory" module #1584
- Includes fix from ci(proto-lint): add github token to prevent rate limit + compare against branch #1612 (preferably, merge this one first to avoid conflicts)
Codecov Report
@@ Coverage Diff @@
## master #1607 +/- ##
==========================================
- Coverage 74.18% 74.08% -0.11%
==========================================
Files 165 175 +10
Lines 13177 14268 +1091
==========================================
+ Hits 9775 10570 +795
- Misses 2855 3096 +241
- Partials 547 602 +55
|
test(tokenfactory): more CLI test coverage feat(perp): Add user discounts (#1594) * add discounts * impl genesis * fix test * make test more robust * galaxy brain int encoding fix * test and optimise * lint * CHANGELOG.md * do merge * clarify fee variable names in applyDiscountAndRebate func * refactor dnr_test.go as per PR review * add genesis tests --------- Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: godismercilex <mercilex@matrixsystems.co> Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> feat(perp): Add user discounts (#1594) * add discounts * impl genesis * fix test * make test more robust * galaxy brain int encoding fix * test and optimise * lint * CHANGELOG.md * do merge * clarify fee variable names in applyDiscountAndRebate func * refactor dnr_test.go as per PR review * add genesis tests --------- Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: godismercilex <mercilex@matrixsystems.co> Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
c9be039
to
06711a4
Compare
I'm encountering something strange here where it says the perp protos are breaking and I'm not even editing those files. Update: Solved by |
} | ||
|
||
ctx := sdk.UnwrapSDKContext(goCtx) | ||
iter := q.Keeper.Store.Denoms.Indexes.Creator.ExactMatch(ctx, req.Creator) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need pagination there in the future. But that should not be an issue just yet
@@ -5,7 +5,7 @@ import ( | |||
) | |||
|
|||
func (s *TestSuite) TestQueryModuleParams() { | |||
res, err := s.queryClient.Params(s.GoCtx(), &types.QueryParamsRequest{}) | |||
res, err := s.querier.Params(s.GoCtx(), &types.QueryParamsRequest{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add query denoms and query denom info tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor details on test, we can merge, but I'd like to talk design to avoid the spamming
Creator: txMsg.Sender, | ||
Subdenom: txMsg.Subdenom, | ||
} | ||
err = k.Store.InsertDenom(ctx, denom) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we avoid people spamming that to do denom flipping (I create [a-z]btc
)? Should we make the user pay some nibi for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It costs 4 full NIBI plus the usual gas for the tx.