feat(tokenfactory): execute msgs for CreateDenom, ChangeAdmin, UpdateModuleParams #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Unique-Divine
commented
Sep 28, 2023
•
Unique-Divine
commented
- Includes queries, transaction messages, and CLI commands for CreateDenom, ChangeAdmin, and UpdateModuleParams
- Part of [epic] feat: "tokenfactory" module #1584
- Includes fix from ci(proto-lint): add github token to prevent rate limit + compare against branch #1612 (preferably, merge this one first to avoid conflicts)
Codecov Report
@@ Coverage Diff @@
## master #1607 +/- ##
==========================================
- Coverage 74.18% 74.08% -0.11%
==========================================
Files 165 175 +10
Lines 13177 14268 +1091
==========================================
+ Hits 9775 10570 +795
- Misses 2855 3096 +241
- Partials 547 602 +55
|
test(tokenfactory): more CLI test coverage feat(perp): Add user discounts (#1594) * add discounts * impl genesis * fix test * make test more robust * galaxy brain int encoding fix * test and optimise * lint * CHANGELOG.md * do merge * clarify fee variable names in applyDiscountAndRebate func * refactor dnr_test.go as per PR review * add genesis tests --------- Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: godismercilex <mercilex@matrixsystems.co> Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> feat(perp): Add user discounts (#1594) * add discounts * impl genesis * fix test * make test more robust * galaxy brain int encoding fix * test and optimise * lint * CHANGELOG.md * do merge * clarify fee variable names in applyDiscountAndRebate func * refactor dnr_test.go as per PR review * add genesis tests --------- Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: godismercilex <mercilex@matrixsystems.co> Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Unique-Divine
force-pushed
the
realu/tf-1
branch
from
c9be039
to
06711a4
Compare
|
I'm encountering something strange here where it says the perp protos are breaking and I'm not even editing those files.
Update: Solved by |
matthiasmatt
reviewed
Oct 3, 2023
matthiasmatt
reviewed
Oct 3, 2023
| } | ||
|
|
||
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
| iter := q.Keeper.Store.Denoms.Indexes.Creator.ExactMatch(ctx, req.Creator) |
There was a problem hiding this comment.
We might need pagination there in the future. But that should not be an issue just yet
matthiasmatt
reviewed
Oct 3, 2023
| @@ -5,7 +5,7 @@ import ( | |||
| ) | |||
|
|
|||
| func (s *TestSuite) TestQueryModuleParams() { | |||
| res, err := s.queryClient.Params(s.GoCtx(), &types.QueryParamsRequest{}) | |||
| res, err := s.querier.Params(s.GoCtx(), &types.QueryParamsRequest{}) | |||
There was a problem hiding this comment.
Can you add query denoms and query denom info tests?
matthiasmatt
approved these changes
Oct 3, 2023
| Creator: txMsg.Sender, | ||
| Subdenom: txMsg.Subdenom, | ||
| } | ||
| err = k.Store.InsertDenom(ctx, denom) |
There was a problem hiding this comment.
How do we avoid people spamming that to do denom flipping (I create [a-z]btc)? Should we make the user pay some nibi for that?
There was a problem hiding this comment.
It costs 4 full NIBI plus the usual gas for the tx.
jgimeno
reviewed
Oct 3, 2023
jgimeno
reviewed
Oct 3, 2023
jgimeno
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.