Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(proto): Use explicit namespacing on proto imports for #1608 #1614

Merged
merged 2 commits into from
Oct 3, 2023
Merged

refactor(proto): Use explicit namespacing on proto imports for #1608 #1614

merged 2 commits into from
Oct 3, 2023

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine requested a review from a team as a code owner October 1, 2023 14:22
matthiasmatt
matthiasmatt approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@matthiasmatt matthiasmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing stablecoin proto is needed but breaking change though!

@jgimeno
Copy link
Contributor

jgimeno commented Oct 3, 2023

Why we do this random stuff? It is not useful and adds noise

jgimeno
jgimeno reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@jgimeno jgimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I dont see why this needs to be done

@Unique-Divine Unique-Divine enabled auto-merge (squash) October 3, 2023 17:55
@Unique-Divine Unique-Divine merged commit 9f53504 into master Oct 3, 2023
14 of 15 checks passed
@Unique-Divine Unique-Divine deleted the realu/proto-namespace branch October 3, 2023 17:58
jgimeno added a commit that referenced this pull request Oct 4, 2023
@jgimeno
Revert "refactor(proto): Use explicit namespacing on proto imports for …
783e52c 
…#1608 (#1614)"

This reverts commit 9f53504.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgimeno jgimeno jgimeno left review comments

@matthiasmatt matthiasmatt matthiasmatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(x): Use explicit namespacing on proto imports
3 participants
@Unique-Divine @jgimeno @matthiasmatt