Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upgrade handler for v1.1.0 #1682

Closed
wants to merge 3 commits into from

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Nov 28, 2023

Description

What does this PR do?

Purpose

Why is this PR important?

@jgimeno jgimeno requested a review from a team as a code owner November 28, 2023 22:27
@jgimeno jgimeno changed the base branch from master to releases/v1.1.0 November 28, 2023 22:27
Copy link
Contributor

coderabbitai bot commented Nov 28, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The project has undergone significant updates, including the introduction of polynomial inflation, removal of perp features, and enhancements to the oracle module. The codebase has shifted from using the wasm package to wasmtypes, and the goreleaser workflow now targets an updated Ubuntu version. The token factory has seen increased focus, and the epochs module has been refined with new identifiers and durations. Additionally, there's a new command for building wasm messages, and strategic reserves now receive minted coins.

Changes

File(s) Summary
.github/workflows/goreleaser.yml Updated runs-on to ubuntu-latest-m.
CHANGELOG.md Documented new features, improvements, and bug fixes across releases.
app/..., cmd/..., contrib/scripts/localnet.sh Adjusted imports and references to align with new features and removal of perp features.
proto/... Renamed messages, updated fields, and added new rpc methods in oracle proto files.
wasmbinding/... Added new package and functions for wasm binding and queries.
x/common/testutil/..., x/devgas/v1/..., x/epochs/..., x/inflation/..., x/oracle/... Extensive updates to tests, types, and keeper logic reflecting new features and module changes.

Poem

In the code where bytes do hop, 🐇💻
A rabbit's work, it never stops.
With each commit, the changes flow,
A polished gem begins to glow. ✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Comment on lines +8 to +13
type Upgrade struct {
UpgradeName string

CreateUpgradeHandler func() types.UpgradeHandler

StoreUpgrades store.StoreUpgrades
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Upgrade struct and its fields should have comments explaining their purpose and usage to improve code maintainability and clarity.

@jgimeno
Copy link
Contributor Author

jgimeno commented Nov 28, 2023

@coderabbitai review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 785841a and 37fac67.
Files selected for processing (2)
  • app/upgrades.go (1 hunks)
  • app/upgrades/v1_1_0/constants.go (1 hunks)
Additional comments: 2
app/upgrades.go (1)
  • 1-42: The changes in app/upgrades.go look good and follow best practices for Go, such as proper error handling and early returns. The upgrade handling logic is clear and maintainable.
app/upgrades/v1_1_0/constants.go (1)
  • 15-17: The CreateUpgradeHandler function currently returns nil. Verify if this is intentional and if an actual upgrade handler function should be implemented to handle the upgrade logic.

@jgimeno jgimeno changed the title feature: add upgrade handler for v1.1.0 feat: add upgrade handler for v1.1.0 Nov 28, 2023
@jgimeno
Copy link
Contributor Author

jgimeno commented Nov 28, 2023

@coderabbitai help

Copy link
Contributor

coderabbitai bot commented Nov 28, 2023

CodeRabbit Commands

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

@jgimeno jgimeno changed the base branch from releases/v1.1.0 to master November 29, 2023 15:22
@jgimeno jgimeno changed the base branch from master to releases/v1.1.0 November 29, 2023 15:23
@jgimeno
Copy link
Contributor Author

jgimeno commented Nov 29, 2023

close in favor of #1684

@jgimeno jgimeno closed this Nov 29, 2023
@k-yang k-yang deleted the feature/upgrade-proposal-inflation branch February 9, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant