-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add upgrade handler for v1.1.0 #1682
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThe project has undergone significant updates, including the introduction of polynomial inflation, removal of perp features, and enhancements to the oracle module. The codebase has shifted from using the Changes
Poem
TipsChat with CodeRabbit Bot (
|
type Upgrade struct { | ||
UpgradeName string | ||
|
||
CreateUpgradeHandler func() types.UpgradeHandler | ||
|
||
StoreUpgrades store.StoreUpgrades |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Upgrade
struct and its fields should have comments explaining their purpose and usage to improve code maintainability and clarity.
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- app/upgrades.go (1 hunks)
- app/upgrades/v1_1_0/constants.go (1 hunks)
Additional comments: 2
app/upgrades.go (1)
- 1-42: The changes in
app/upgrades.go
look good and follow best practices for Go, such as proper error handling and early returns. The upgrade handling logic is clear and maintainable.app/upgrades/v1_1_0/constants.go (1)
- 15-17: The
CreateUpgradeHandler
function currently returnsnil
. Verify if this is intentional and if an actual upgrade handler function should be implemented to handle the upgrade logic.
@coderabbitai help |
CodeRabbit Commands
|
close in favor of #1684 |
Description
What does this PR do?
Purpose
Why is this PR important?