-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle case where skip epoch not aligned with epoch passed #1796
Conversation
WalkthroughThe changes involve enhancing the inflation mechanism within a blockchain application, focusing on epoch handling and localnet configuration adjustments. Key updates include adding epoch-related functionality to the inflation keeper, refining localnet setup scripts with better flag parsing and settings, and incorporating tests for manual verification of inflation adjustments. These modifications aim to improve the robustness and flexibility of inflation control and development environment setup. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (6)
- app/keepers.go (1 hunks)
- contrib/scripts/localnet.sh (5 hunks)
- x/inflation/keeper/hooks_test.go (3 hunks)
- x/inflation/keeper/keeper.go (3 hunks)
- x/inflation/keeper/sudo.go (2 hunks)
- x/inflation/types/interfaces.go (2 hunks)
Additional comments: 9
x/inflation/types/interfaces.go (1)
- 50-52: LGTM!
x/inflation/keeper/keeper.go (2)
- 26-26: LGTM!
- 42-48: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [45-61]
LGTM!
x/inflation/keeper/sudo.go (1)
- 61-71: LGTM!
contrib/scripts/localnet.sh (3)
- 39-41: LGTM!
- 56-63: LGTM!
- 235-236: LGTM!
x/inflation/keeper/hooks_test.go (1)
- 266-287: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [219-285]
LGTM!
app/keepers.go (1)
- 382-382: The addition of
app.EpochsKeeper
as an argument toInflationKeeper
'sNewKeeper
function call is correctly implemented, aligning with the PR objectives to enhance epoch handling in the inflation mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- x/inflation/keeper/hooks_test.go (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- x/inflation/keeper/hooks_test.go
Additional comments: 1
CHANGELOG.md (1)
- 63-63: LGTM!
Purpose / Abstract
Summary by CodeRabbit