Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle case where skip epoch not aligned with epoch passed #1796

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

matthiasmatt
Copy link
Contributor

@matthiasmatt matthiasmatt commented Feb 14, 2024

Purpose / Abstract

  • Closes #AAA

Summary by CodeRabbit

  • New Features
    • Introduced a new interface for retrieving epoch information, enhancing the inflation functionality.
    • Updated the local network script to improve configuration handling and added CORS support.
  • Enhancements
    • Improved inflation keeper initialization with enhanced epoch handling.
    • Enhanced test coverage for inflation functionality, including scenarios of turning inflation on and off.
  • Bug Fixes
    • Fixed an issue with skipped epochs in inflation calculations to ensure accurate balance updates.

@matthiasmatt matthiasmatt requested a review from a team as a code owner February 14, 2024 19:08
Copy link
Contributor

coderabbitai bot commented Feb 14, 2024

Walkthrough

The changes involve enhancing the inflation mechanism within a blockchain application, focusing on epoch handling and localnet configuration adjustments. Key updates include adding epoch-related functionality to the inflation keeper, refining localnet setup scripts with better flag parsing and settings, and incorporating tests for manual verification of inflation adjustments. These modifications aim to improve the robustness and flexibility of inflation control and development environment setup.

Changes

Files Summary
app/keepers.go, .../keeper/keeper.go Added EpochsKeeper to InflationKeeper initialization for better epoch handling.
contrib/scripts/localnet.sh Updated flag parsing, localnet configurations, and added CORS and genesis parameters.
.../keeper/hooks_test.go Updated tests to include manual inflation functionality verification with epoch considerations.
x/inflation/keeper/sudo.go Added logic for handling skipped epochs in ToggleInflation.
x/inflation/types/interfaces.go Introduced EpochsKeeper interface for retrieving epoch information.

🐇✨
In the realm of code, where the bits align,
Changes unfold, with purpose divine.
Epochs dance, inflation in check,
A script refines, with no speck.
🌟 Through the keeper's wise new trait,
Our blockchain's pulse beats steady and great.
🥕🎉 Celebrate we shall, for progress we chase,
In the digital burrow, our ever-evolving space.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@matthiasmatt matthiasmatt enabled auto-merge (squash) February 14, 2024 19:10
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 04c136c and 83df96a.
Files selected for processing (6)
  • app/keepers.go (1 hunks)
  • contrib/scripts/localnet.sh (5 hunks)
  • x/inflation/keeper/hooks_test.go (3 hunks)
  • x/inflation/keeper/keeper.go (3 hunks)
  • x/inflation/keeper/sudo.go (2 hunks)
  • x/inflation/types/interfaces.go (2 hunks)
Additional comments: 9
x/inflation/types/interfaces.go (1)
  • 50-52: LGTM!
x/inflation/keeper/keeper.go (2)
  • 26-26: LGTM!
  • 42-48: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [45-61]

LGTM!

x/inflation/keeper/sudo.go (1)
  • 61-71: LGTM!
contrib/scripts/localnet.sh (3)
  • 39-41: LGTM!
  • 56-63: LGTM!
  • 235-236: LGTM!
x/inflation/keeper/hooks_test.go (1)
  • 266-287: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [219-285]

LGTM!

app/keepers.go (1)
  • 382-382: The addition of app.EpochsKeeper as an argument to InflationKeeper's NewKeeper function call is correctly implemented, aligning with the PR objectives to enhance epoch handling in the inflation mechanism.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 83df96a and 91d3ea3.
Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • x/inflation/keeper/hooks_test.go (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • x/inflation/keeper/hooks_test.go
Additional comments: 1
CHANGELOG.md (1)
  • 63-63: LGTM!

@matthiasmatt matthiasmatt merged commit f721571 into main Feb 14, 2024
13 checks passed
@matthiasmatt matthiasmatt deleted the mat/remove-next-skippedepoch branch February 14, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants