Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pebbledb support #1818

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat: add pebbledb support #1818

merged 1 commit into from
Mar 5, 2024

Conversation

helder-moreira
Copy link
Contributor

@helder-moreira helder-moreira commented Mar 5, 2024

Purpose / Abstract

  • Closes #AAA

Summary by CodeRabbit

  • New Features
    • Added support for pebbledb in builds, enhancing database configuration options.
  • Chores
    • Updated CHANGELOG to reflect the addition of pebbledb support.

@helder-moreira helder-moreira requested a review from a team as a code owner March 5, 2024 16:52
Copy link
Contributor

coderabbitai bot commented Mar 5, 2024

Walkthrough

The project has enhanced its capabilities by adding support for pebbledb. This addition spans various configurations and build processes, involving updates in .goreleaser.yml for build configurations, a mention in CHANGELOG.md documenting the pull request introducing pebbledb support, and a modification in build.mk to include pebbledb in the build tags alongside existing tags like netgo, osusergo, ledger, static, and `rocksdb.

Changes

Files Change Summary
.goreleaser.yml, CHANGELOG.md
contrib/make/build.mk
Added pebbledb support across configurations and build processes. Included in build tags and documented in PR #1818.

🐰✨

In the code's vast warren, a new stone was laid,

PebbleDB, in our toolkit, now proudly displayed.

Through pull requests and changes, our journey we chart,

With each tag and build, a fine engineer's art.

So hop with joy, for our code now expands,

With pebbles and rocks, built by our hands.

🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between dd45afe and c3da716.
Files ignored due to path filters (2)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum
Files selected for processing (3)
  • .goreleaser.yml (2 hunks)
  • CHANGELOG.md (1 hunks)
  • contrib/make/build.mk (1 hunks)
Additional comments: 3
.goreleaser.yml (2)
  • 43-43: The addition of pebbledb to the darwin build tags is correctly implemented and aligns with the PR's objective to introduce PebbleDB support.
  • 83-83: The addition of pebbledb to the linux build tags is correctly implemented, ensuring PebbleDB support in both static and muslc configurations for Linux builds.
contrib/make/build.mk (1)
  • 42-42: The addition of pebbledb to the build_tags variable is correctly implemented, aligning with the PR's objective to introduce PebbleDB support and maintaining the conditional logic for tag inclusion based on the operating system.

CHANGELOG.md Outdated
@@ -104,6 +104,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#1778](https://github.com/NibiruChain/nibiru/pull/1778) - chore: bump librocksdb to v8.9.1
- [#1799](https://github.com/NibiruChain/nibiru/pull/1799) - refactor,docs(inflation): Document everything + delete unused code. Make perp and spot optional features in localnet.sh
- [#1810](https://github.com/NibiruChain/nibiru/pull/1810) - chore(ci): use ubuntu-latest-m for goreleaser
- [#1816](https://github.com/NibiruChain/nibiru/pull/1816) - feat: add pebbledb support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry for adding PebbleDB support references pull request #1816, but this pull request is numbered 1818. Please verify the correct pull request number for documenting PebbleDB support.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between dd45afe and c4b529f.
Files ignored due to path filters (2)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum
Files selected for processing (3)
  • .goreleaser.yml (2 hunks)
  • CHANGELOG.md (1 hunks)
  • contrib/make/build.mk (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • .goreleaser.yml
  • CHANGELOG.md
  • contrib/make/build.mk

@helder-moreira helder-moreira merged commit dbdf02d into main Mar 5, 2024
13 checks passed
@helder-moreira helder-moreira deleted the feat/pebble-db-support branch March 5, 2024 22:54
k-yang pushed a commit that referenced this pull request May 18, 2024
k-yang pushed a commit that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants