-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pebbledb support #1818
Conversation
WalkthroughThe project has enhanced its capabilities by adding support for Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.mod
is excluded by:!**/*.mod
go.sum
is excluded by:!**/*.sum
Files selected for processing (3)
- .goreleaser.yml (2 hunks)
- CHANGELOG.md (1 hunks)
- contrib/make/build.mk (1 hunks)
Additional comments: 3
.goreleaser.yml (2)
- 43-43: The addition of
pebbledb
to thedarwin
build tags is correctly implemented and aligns with the PR's objective to introduce PebbleDB support.- 83-83: The addition of
pebbledb
to thelinux
build tags is correctly implemented, ensuring PebbleDB support in bothstatic
andmuslc
configurations for Linux builds.contrib/make/build.mk (1)
- 42-42: The addition of
pebbledb
to thebuild_tags
variable is correctly implemented, aligning with the PR's objective to introduce PebbleDB support and maintaining the conditional logic for tag inclusion based on the operating system.
CHANGELOG.md
Outdated
@@ -104,6 +104,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
- [#1778](https://github.com/NibiruChain/nibiru/pull/1778) - chore: bump librocksdb to v8.9.1 | |||
- [#1799](https://github.com/NibiruChain/nibiru/pull/1799) - refactor,docs(inflation): Document everything + delete unused code. Make perp and spot optional features in localnet.sh | |||
- [#1810](https://github.com/NibiruChain/nibiru/pull/1810) - chore(ci): use ubuntu-latest-m for goreleaser | |||
- [#1816](https://github.com/NibiruChain/nibiru/pull/1816) - feat: add pebbledb support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry for adding PebbleDB support references pull request #1816, but this pull request is numbered 1818. Please verify the correct pull request number for documenting PebbleDB support.
c3da716
to
c4b529f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.mod
is excluded by:!**/*.mod
go.sum
is excluded by:!**/*.sum
Files selected for processing (3)
- .goreleaser.yml (2 hunks)
- CHANGELOG.md (1 hunks)
- contrib/make/build.mk (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- .goreleaser.yml
- CHANGELOG.md
- contrib/make/build.mk
Purpose / Abstract
Summary by CodeRabbit
pebbledb
in builds, enhancing database configuration options.pebbledb
support.