-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ica): ICA Host / Controller integration #1820
Conversation
WalkthroughThe updates encompass integrating the interchain accounts module into a blockchain application framework. Notable improvements include adding keepers and store keys for interchain accounts, updating the IBC router for new routes, and preparing for upgrades related to interchain accounts. Additionally, a new formatting target in the build process enhances code consistency. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Looks good also clean. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1820 +/- ##
==========================================
- Coverage 73.07% 69.65% -3.43%
==========================================
Files 196 199 +3
Lines 15564 11987 -3577
==========================================
- Hits 11374 8350 -3024
+ Misses 3526 3090 -436
+ Partials 664 547 -117
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
* ICA Host / Controller integration. Added upgrade constants. Added make format command * Fixed required message URLs * Code import fix * Fixed upgrade name * Fixed upgrade target * Changed version number * Update CHANGELOG.md --------- Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Kevin Yang <5478483+k-yang@users.noreply.github.com>
Purpose / Abstract
This PR introduces the ICA integration to the Nibiru Chain.
make format
command to your makefile to clean up the code following Golang principles.Tests
Unit tests are running fine, but the upgrade must be tested properly by trying to execute ICA operations on Nibiru testnet.
Summary by CodeRabbit
New Features
Refactor
Chores