Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(perp): RemoveMargin keeper method #723

Merged
merged 6 commits into from
Jul 21, 2022
Merged

refactor(perp): RemoveMargin keeper method #723

merged 6 commits into from
Jul 21, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

  • break down msg fields in perp msg server
  • call perp keeper's RemoveMargin method with fields
  • add test coverage

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner July 20, 2022 20:01
@NibiruHeisenberg NibiruHeisenberg linked an issue Jul 20, 2022 that may be closed by this pull request
refactor(perp): MsgServer's RemoveMargin should parse the request before calling the keeper #706
Closed
@NibiruHeisenberg NibiruHeisenberg self-assigned this Jul 20, 2022
@NibiruHeisenberg NibiruHeisenberg changed the title refactor(perp): RemoveMargin keeper method refactor(perp): RemoveMargin keeper method Jul 20, 2022
@AgentSmithMatrix AgentSmithMatrix merged commit e9b4dec into master Jul 21, 2022
@AgentSmithMatrix AgentSmithMatrix deleted the refactor/perp/remove-margin branch July 21, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgentSmithMatrix AgentSmithMatrix AgentSmithMatrix approved these changes

Assignees

@NibiruHeisenberg NibiruHeisenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(perp): MsgServer's RemoveMargin should parse the request before calling the keeper
2 participants
@NibiruHeisenberg @AgentSmithMatrix