-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oracle): implement reward allocation for oracles #839
Conversation
…cilex/oracle-wiring
# Conflicts: # CHANGELOG.md # app/app.go
# Conflicts: # x/oracle/keeper/ballot_test.go # x/oracle/keeper/tally_fuzz_test.go # x/oracle/keeper/update_exchange_rate_test.go # x/oracle/keeper/update_exchange_rates.go
@@ -13,15 +13,17 @@ func NewGenesisState( | |||
aggregateExchangeRatePrevotes []AggregateExchangeRatePrevote, | |||
aggregateExchangeRateVotes []AggregateExchangeRateVote, | |||
pairs []Pair, | |||
pairRewards []*PairReward, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why slice of pointers here and not regular slice like the other arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will address this in the next PR.
Not doing it RN just to avoid merge conflicts with the other PR, since it's a pretty small change, I can address it there.
I'll merge this for now.
closes: #805
depends on: #835