feat(oracle): implement reward allocation for oracles #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cilex/oracle-wiring
# Conflicts: # CHANGELOG.md # app/app.go
added 9 commits
August 22, 2022 22:07
added 9 commits
August 23, 2022 10:34
testinginprod
changed the title
added 2 commits
August 24, 2022 10:58
Base automatically changed from
mercilex/oracle-remove-pick-reference-pair
to
master
August 24, 2022 15:37
# Conflicts: # x/oracle/keeper/ballot_test.go # x/oracle/keeper/tally_fuzz_test.go # x/oracle/keeper/update_exchange_rate_test.go # x/oracle/keeper/update_exchange_rates.go
NibiruHeisenberg
approved these changes
Aug 25, 2022
| @@ -13,15 +13,17 @@ func NewGenesisState( | |||
| aggregateExchangeRatePrevotes []AggregateExchangeRatePrevote, | |||
| aggregateExchangeRateVotes []AggregateExchangeRateVote, | |||
| pairs []Pair, | |||
| pairRewards []*PairReward, | |||
There was a problem hiding this comment.
Why slice of pointers here and not regular slice like the other arguments?
There was a problem hiding this comment.
I will address this in the next PR.
Not doing it RN just to avoid merge conflicts with the other PR, since it's a pretty small change, I can address it there.
I'll merge this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #805
depends on: #835