Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Fix and enhance oneclick installing & custom scheme handler #459

Merged

Conversation

Mai-Lapyst
Copy link
Contributor

This PR contains:

  • A little typo fix when generating the .desktop file
  • Enhancement for the .desktop file (proper idention of the resulting file)
  • Enhancement of the oneclick installing process in general: now showing a loading spinner so users dont get confused why nothing hapens in the application

@GingerAvalanche
Copy link
Collaborator

I assume you've tested this, and it performs as you want it to? There are no issues with the mods getting marked (or not) as 'installable' as they finish downloading?

@Mai-Lapyst
Copy link
Contributor Author

Mai-Lapyst commented Dec 7, 2022

No, there are none. Despite that, for potential errors I added a commit that sends any catched error to the frontend to display for the user. Because user can potentially have multiple mods downloading & failing at the same time, I simply added a new button to the row when a mods has errors which opens the error modal.

@GingerAvalanche
Copy link
Collaborator

Looks good to me. Thanks for your contribution.

@GingerAvalanche GingerAvalanche merged commit 36d0b5f into NiceneNerd:master Dec 8, 2022
@Mai-Lapyst Mai-Lapyst deleted the enhance-oneclick-install branch December 8, 2022 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants