This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
handling tabs, and select box update, preserve option order in select box #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be overridden, to either escape or submit the form. Also allow the enter key to submit the form if no submit button is present, on a select input.
… gets rid of an extra loop.
…he order given...
|
Hello, Thank you for your contribution. I didn't include the tab stuff because it was not working in my hands. I removed the extra loop. I didn't include the 3rd thing. Please make a new PR with just this change if it's still needed/wanted. |
NicolasCARPi
added a commit
that referenced
this pull request
Dec 19, 2017
|
It's been 6 years, I don't even remember what I needed it for! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes I've made while integrating with KeyTable:
0ca8b7f hitting tab can either escape or submit, and hitting enter on a select also submits.
39b77de removed extra loop from logic that sets the selected item. It works in IE for me, despite what the comment says.
I want to simplify the select code to make way for working on your ticket #24... allowing the json list of options be either a hash (unordered) or keep the order given by using an array of arrays.
a3c0435 allows for array of arrays to preserve option order.
If you can show me that removing the loop doesn't work in IE, the other option is to just store the option in a variable and then set it; I still don't think another loop is needed.