Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

handling tabs, and select box update, preserve option order in select box #45

Closed
wants to merge 3 commits into from
Closed

handling tabs, and select box update, preserve option order in select box #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ca8b7f
Added config option "ontab" which allows for the default tab action t…
dgm Jul 17, 2011
39b77de
I cannot duplicate problem with 7d8f7357 - this code works in IE. T…
dgm Jul 22, 2011
a3c0435
adding support for an array of arrays json data object, to preserve t…
dgm Jul 22, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
53 changes: 39 additions & 14 deletions jquery.jeditable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
* @param String options[select] true or false, when true text is highlighted ??
* @param String options[placeholder] Placeholder text or html to insert when element is empty. **
* @param String options[onblur] 'cancel', 'submit', 'ignore' or function ??
* @param String options[ontab] 'submit', or 'escape', block default browser tab action and take our own action
*
* @param Function options[onsubmit] function(settings, original) { ... } called before submit
* @param Function options[onreset] function(settings, original) { ... } called before reset
Expand Down Expand Up @@ -261,6 +262,15 @@
e.preventDefault();
reset.apply(form, [settings, self]);
}
if (e.keyCode === 9) {
if (settings.ontab === "escape") {
e.preventDefault();
reset.apply(form, [settings, self]);
} else if (settings.ontab === "submit"){
e.preventDefault();
form.submit();
}
}
});

/* Discard, submit or nothing with changes when clicking outside. */
Expand Down Expand Up @@ -492,29 +502,44 @@
/* Otherwise assume it is a hash already. */
var json = data;
}
for (var key in json) {
if (!json.hasOwnProperty(key)) {
continue;
for (var item in json) {
var option_key;
var option_value;
if ($.isArray(json)) {
option_key = json[item][0];
option_value = json[item][1];
} else {
if (!json.hasOwnProperty(item)) {
continue;
}
option_key = item;
option_value = json[item];
}
if ('selected' == key) {

if ('selected' == option_key) {
continue;
}
var option = $('<option />').val(key).append(json[key]);
$('select', this).append(option);
}
/* Loop option again to set selected. IE needed this... */
$('select', this).children().each(function() {
if ($(this).val() == json['selected'] ||
$(this).text() == $.trim(original.revert)) {
$(this).attr('selected', 'selected');
}
});
var option = $('<option />').val(option_key).append(option_value);
if (option_key == json['selected'] ||
option_value == $.trim(original.revert)) {
$(option).attr('selected', 'selected');
}
$('select', this).append(option);
}

/* Submit on change if no submit button defined. */
if (!settings.submit) {
var form = this;
$('select', this).change(function() {
form.submit();
});
/* also allow enter to submit, even if no change */
$('select', this).keydown(function(e) {
if (e.keyCode == 13) {
e.preventDefault();
form.submit();
}
});
}
}
}
Expand Down