Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fatal error: Maximum execution time" when a few "Display [provider] preferences" are enabled #2

Closed
maniqui opened this issue Mar 2, 2017 · 5 comments
Labels

Comments

@maniqui
Copy link

maniqui commented Mar 2, 2017

I'm still tracking this down. I'm getting a:

Fatal error: Maximum execution time of 30 seconds exceeded in /home/sites/xxxxxxx/public/textpattern/lib/txplib_misc.php on line 1902

when I activate a few preferences (Soundcloud, Mixcloud, Vimeo, Youtube). I'm not sure if it's related to the amount of DB fields it has to fetch for the whole Preferences screen or if it's related to some of the oui_player preferences. I think it might be an issue with Soundcloud/Mixcloud preferences, although I've to prove that yet.

@maniqui
Copy link
Author

maniqui commented Mar 2, 2017

It might be related. See on the screenshot below, how Soundcloud preferences are enabled and Mixcloud are disabled, but on the left tabs, the Mixcloud link is shown and the Soundcloud link is missing.

image

@NicolasGraph
Copy link
Owner

Thanks @maniqui for the report, I'll try to reproduce and fix it next week.

@NicolasGraph
Copy link
Owner

NicolasGraph commented Mar 9, 2017

Inversed provider prefs are related the en-gb textpack; I fixed it in the dev branch; no big deal.

@NicolasGraph
Copy link
Owner

@maniqui, I think you are right about the amount of DB fields.
I'm not sure about the better way to avoid that.

On my side I could:

  • use a select list to display players prefs only one by one, but it wouldn't be ideal;
  • code a extension tab to display the plugin related prefs only, but I need more time and a way to exclude these prefs from the regular preferences tab…

I'll investigate…

In the meanwhile, you can:

  • raise your time limit;
  • avoid to display too many players prefs at the same time (hidding them after customization before to display others).

@NicolasGraph
Copy link
Owner

NicolasGraph commented Mar 27, 2017

@maniqui, I performed more tests and found an issue concerning the prefWidget()function used to automatically display the right widget for each plugin prefs according to valid values. It really slows the prefs display when too many of them are enable. I'm working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants