Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow esnext module import #10

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Conversation

drochgenius
Copy link

Hi @Niekes,

I'd like to use your library as an es module, alongside other D3 modules in my application, and I need the module field in package.json to be set properly.
This field is currently a proposal, but it's already implemented in other D3 modules: https://github.com/d3/d3-shape/blob/master/package.json#L22

The proposal is here for more details: https://github.com/rollup/rollup/wiki/pkg.module

Thanks for reviewing

@drochgenius
Copy link
Author

Hi @Niekes , could you please review my PR?

Thanks

@Niekes Niekes merged commit d7fee6f into Niekes:master Jan 22, 2019
@Niekes
Copy link
Owner

Niekes commented Jan 22, 2019

sorry for the delay...

@drochgenius
Copy link
Author

NP, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants