Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Fixes issue #116: Browsers.iOS < 4.2 wouldn't work for non-iOS browsers #117

Merged
merged 1 commit into from Jan 5, 2012

Conversation

ghost
Copy link

@ghost ghost commented Jan 5, 2012

No description provided.

@ghost
Copy link
Author

ghost commented Jan 5, 2012

for example in function canPlayType

canPlayType: function(t) {
/*
There is a bug in iOS 4.1 or earlier where probably and maybe are switched around.
This bug was reported and fixed in iOS 4.2
*/

            if (Browsers.iOS < 4.2)
                return this.element.canPlayType(t) == 'probably' || this.element.canPlayType(t) == 'maybe';
            else 
                return this.element.canPlayType(t) == 'probably';
        }

If I use Android browser, Browsers.iOS is false, and Browsers.iOS < 4.2 is going to be true. But you probably want Browsers.iOS < 4.2 to be false if I'm using non-iOS browser.

NielsLeenheer added a commit that referenced this pull request Jan 5, 2012
Fixes issue #116: Browsers.iOS < 4.2 wouldn't work for non-iOS browsers
@NielsLeenheer NielsLeenheer merged commit e2b2f66 into WebPlatformTest:master Jan 5, 2012
@NielsLeenheer
Copy link
Collaborator

Thanks, I'll publish this change right away.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants