Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixes issue #116: Browsers.iOS < 4.2 wouldn't work for non-iOS browsers #117

Merged
merged 1 commit into from

2 participants

@ghost

No description provided.

@ghost

for example in function canPlayType

canPlayType: function(t) {
/*
There is a bug in iOS 4.1 or earlier where probably and maybe are switched around.
This bug was reported and fixed in iOS 4.2
*/

            if (Browsers.iOS < 4.2)
                return this.element.canPlayType(t) == 'probably' || this.element.canPlayType(t) == 'maybe';
            else 
                return this.element.canPlayType(t) == 'probably';
        }

If I use Android browser, Browsers.iOS is false, and Browsers.iOS < 4.2 is going to be true. But you probably want Browsers.iOS < 4.2 to be false if I'm using non-iOS browser.

@NielsLeenheer NielsLeenheer merged commit e2b2f66 into from
@NielsLeenheer

Thanks, I'll publish this change right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 index.html
View
4 index.html
@@ -2368,7 +2368,7 @@
This bug was reported and fixed in iOS 4.2
*/
- if (Browsers.iOS < 4.2)
+ if (Browsers.iOS && Browsers.iOS < 4.2)
return this.element.canPlayType(t) == 'probably' || this.element.canPlayType(t) == 'maybe';
else
return this.element.canPlayType(t) == 'probably';
@@ -2466,7 +2466,7 @@
This bug was reported and fixed in iOS 4.2
*/
- if (Browsers.iOS < 4.2)
+ if (Browsers.iOS && Browsers.iOS < 4.2)
return this.element.canPlayType(t) == 'probably' || this.element.canPlayType(t) == 'maybe';
else
return this.element.canPlayType(t) == 'probably';
Something went wrong with that request. Please try again.