Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error trapping for species inputs #58

Closed
jcsutherland opened this issue Jul 15, 2019 · 1 comment · Fixed by #63
Closed

Add error trapping for species inputs #58

jcsutherland opened this issue Jul 15, 2019 · 1 comment · Fixed by #63

Comments

@jcsutherland
Copy link

If a species is "retained" or "target" and isn't found in the cantera input file, that error should be trapped. It is presently silently ignored, which can give unexpected results. Also note that the species names are case-sensitive.
@jcsutherland jcsutherland mentioned this issue Jul 15, 2019
Closed
36 tasks
@kyleniemeyer
Copy link
Member

Good catch, thanks.

kyleniemeyer added a commit to kyleniemeyer/pyMARS that referenced this issue Jul 19, 2019
@kyleniemeyer
Changes most reduction inputs to YAML file. Closes Niemeyer-Research-…
e6ec139 
…Group#59, closes Niemeyer-Research-Group#58, and closes Niemeyer-Research-Group#57.

These changes move all reduction-specific inputs to a YAML file, which
also includes the sampling input parameters (autoignition only for now).
As part of this, pyMARS now checks the inputs for correctness and consistency,
including that species included as targets, always retained, and as
fuel/oxidizer/reactant are actually in the starting model. Tests are
updated to reflect these changes, though documentation has not yet
been updated.
@kyleniemeyer kyleniemeyer mentioned this issue Jul 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JOSS fixes: resolves jcsutherland issues kyleniemeyer/pyMARS
2 participants
@kyleniemeyer @jcsutherland