Use correct scrambled password function (issue #29) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my_make_scrambled_password() is not meant to be a replacement for the removed make_scrambled_password() function from libmysqlclient. So look for make_scrambled_password() in the mysql client library instead of my_make_scrambled_password(). If not found, then reimplement it, but with the correct name to avoid further confusion around this.
Use the make_scrambled_password() function as declared in the mysql headers.
panlinux
changed the title
NigelCunningham
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a suggested fix. It will try to use mysql's make_scrambled_password() if it exists, and your own implementation if it doesn't.
To match the headers from mysql, I had to change the implementation to drop the last length argument.
Finally, I also changed hexify to return capital letters, as that is how the hex string is stored on the mysql server when using the PASSWORD() function.