New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stephen-hardy / xlsx.js enhancements #10
Comments
If you are forking stephen-hardy/xlsx.js, you have to distribute under the Microsoft Office Extensible File License (section 3D). That's not where you run into trouble, though. The real problem for you comes when you want to use this for your projects (emphasis mine):
This is a usage issue, though, and doesn't affect your ability to make contributions or release your code. You are free to create a github repo and release the code. If you do decide to release enhancements to xlsx.js, note that section 3D makes it difficult to use the those contributions in a project that isn't licensed with their version ("any portion of the software", which your contributions would be). If I felt so inclined, I'd probably raise an issue about it in your project :) If it is not too crass to ask, why not contribute to this project directly? Since this is a clean-room implementation from the ISO standard and was licensed under the MIT license from inception, there's no question that others can use your contributions (and I won't have to scrutinize any future contributions from you to ensure that we don't accidentally violate the other project's license). tl;dr: Its ok to make your fork and publish, but you have to use the Microsoft Office Extensible File License. Watch how you are using the code after you do so. If this does give you pause, consider contributing to this project :) |
Thanks Niggler for your fast response. I've already forked your project. I'll try to migrate my code to be Cheers! 2013/3/15 Niggler notifications@github.com
|
Pull requests are always welcome, and I'm glad to see you found use for this! |
Breaks references in style objects
- dateNF option for default date format override - general format renders undefined/null as empty string - ignore text elements when searching for decimal point - bubble negative sign to the front when format starts with text - fixes for eslint + closure - updated frac to 1.0.6 Issues: - fixes #10 h/t @adamgundy @SegFaultx64 @RichardCzechowski - fixes #15 h/t @wilg - fixes #25 h/t @dougschiller - fixes #26 h/t @rjmcguire
Hi Niggler. I found your work on xlsx file thanks to license discussion on stephen-hardy implementation. I'm one of those persons just too lazy to read license files.
I needed to write Excel files to export data from my webpage and I found his code on GitHub. I forked his work and added support for cell styling, to be able to change fonts, borders, colors, etc., and I rewrote almost every line of his export code to make it dinamically created (his version has fixed parameters). I wanted to share my code but found this licensing problem with his code and I need to know how can I proceed. Can you give me an advise on this matter?
Thanks!
The text was updated successfully, but these errors were encountered: