New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested Imports minor improvements #134

Merged

NightrainsRbx merged 4 commits into NightrainsRbx:master from Corecii:suggest-imports

Jan 5, 2022

Contributor

Corecii commented Jan 5, 2022 •

edited

Loading

There were a few changes I wanted to add before the merge of the last pr: (sorry for any confusion!)

"Shortest First" import type, so you can use relative vs absolute paths based on what's shortest
importAlwaysAbsolute setting, so some directories can be set to always use absolute paths
Set the default import type to "Both", so it'll be compatible with everyone's codebase and conventions by default.
Properly ignore wally index in ignoreDir (this was partially added by accident before, this fixes it by adding it fully)

Corecii added 4 commits

January 4, 2022 18:12


          Add Shortest First import type


          Add importAlwaysAbsolute setting

967c709


          Set default import type to Both

49d4f66


          Ignore wally index by default (ignoreDir)

fb1b300

Corecii mentioned this pull request

Suggest imports when using an undefined variable #123

Merged

NightrainsRbx merged commit 382b812 into NightrainsRbx:master

Owner

NightrainsRbx commented Jan 5, 2022

I think this is okay, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet