Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more notification sounds #2

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Conversation

AdrianLxM
Copy link
Contributor

There are very little and easily overhearable notification sounds on some phones.

The parameter "all" gives also access to the ringtones and alarm sounds (better for the low predictive alert).

@jamorham
Copy link
Collaborator

Do ringtone sounds automatically loop? For some reason I thought they did. I'm wondering what that will do if so.

@AdrianLxM
Copy link
Contributor Author

Do ringtone sounds automatically loop?

On my phone they don't. With the standard alarm system the automatic loop had to be triggered as well.

Looping the low predict alarm until the notification is acknowledged would be a great extra feature but at the moment I'm happy to have something that sounds a bit longer (but stops as soon as I dismiss the Notification) :)

Copy link
Collaborator

@jamorham jamorham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we need to test this more widely to see what happens on various phones when various tones are selected and whether the behavior is as would be expected. Planning to merge and test.

@jamorham jamorham merged commit 15e1893 into master Sep 26, 2016
@AdrianLxM AdrianLxM deleted the adrian-moreAlertSounds branch September 26, 2016 22:25
jamorham pushed a commit that referenced this pull request Sep 22, 2017
jamorham pushed a commit that referenced this pull request Oct 7, 2017
jamorham pushed a commit that referenced this pull request Feb 13, 2018
jamorham pushed a commit that referenced this pull request Jun 20, 2018
Merge Latest for jamorham/xDrip-plus/master
jamorham pushed a commit that referenced this pull request Jun 27, 2018
jamorham pushed a commit that referenced this pull request Nov 2, 2019
jamorham pushed a commit that referenced this pull request Oct 8, 2023
CareLink reCAPTCHA login using WebView
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants