-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for libre pro. #2075
Conversation
|
||
|
||
// Get the trend data for libre1/2 | ||
private static ArrayList<GlucoseData> parseTrendData(byte[] data, int sensorTime, long sensorStartTime, Long CaptureDateTime) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parseHistoryData
and parseTrendData
are almost identical with the exception of the index (26 vs 27) and data size (16 vs 32). To reduce code duplication these two functions could be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gui-dos I've just compared parseHistoryData
and parseTrendData
and the code is identical with the exception of the two mentioned cases. These can be parameterized. If the Libre Pro history ist totally different than something else should be implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will it fix #1329?
It should fix #1329. As referenced there the LimiTTer transmitter supports Libre Pro. That code base was used for this PR. |
I think that parsing the history is not realy feasible. We are using devices like miaomiao and their fw needs to change in order to support that. From what I read in their website they do not support history as well. |
I agree on history readings. The need to have modified firmware in the given transmitter models to even access the history data structures is not feasible. |
Can you please see what you have in your logs? Thanks |
There was a problem with the checksum. |
Good thing is that the logs show that you have received two different points, so we are making progresses. Next step is to enable more logging, collect data of 30 minutes, and send it to me: Than please press on the 3 points on the right side, import export features->export database. There is also a chance that if you wait longer it will ask for calibration, but I guess that I'll know more once I'll receive the logs. |
17b372a
to
b5537f5
Compare
A short update. The latest version has been working well on libre pro sensors. I have added more checksum checks and more tests to see that nothing is broken. Here is a link to the latest version: |
Thank to all developers for libre pro version for india,thabk you very much from all |
@saurabh1480 Does it work? |
Yes it does work like a GEM..!!..thank you for making this change.. |
Thanks go to @tzachi-dar and @keencave |
Please confirm this is tested and ready for merge? I have other changes relating to Libre so I will merge this first if its looking good. @tzachi-dar |
Yes..XDrip is working fine in all aspects with libre pro.. |
Just a quick comment on this - can we still not get history values from the libre pro? It seems there are a few major caveats with the current code for it
This means that we'd have to keep scanning the sensor? Since this is only the instantaneous reading within the last minute, whereas the whole point of the sensor is not to need to scan it all the time |
Based on information and code that I have received from @keencave
This is not tested as I don't have libre pro sensors.
Would be nice if someone with such a sensor can check this.
Should work with direct nfc scan or devices like miaomiao.
Can be downloaded from: https://drive.google.com/file/d/1VGVvnx-ktEsvHfuxSHm9RJ8KsJtWuIsF/view?usp=sharing