CareLink Follower - Optimized HTTP client, translatable texts, server communication error #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized HTTP client usage
Reuse same HTTP client in every call.
Handling server communication error
Sometimes either at the initial background HTTP request or later at the login page CareLink server resets the connection. This seems to happen if there was a recent request or multiple login attempts from the same IP or just because maybe CareLink is overloaded. An error detection logic and alert dialog was added for this issue.
Translatable texts
Messages, popup texts were moved to translatable strings.