[T132352] Add filters to interface, minor styling and semantic changes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% endif %} | ||
| {% endblock flashes %} | ||
| {% endblock flashes %} | ||
| </section> |
There was a problem hiding this comment.
This gives the banners under its own <section>
MusikAnimal
force-pushed
the
filters
branch
3 times, most recently
from
5dfd6ad
to
d1b3fed
Compare
|
+2 |
MusikAnimal
force-pushed
the
filters
branch
3 times, most recently
from
5dd16be
to
d962243
Compare
|
|
||
| switch ( $filter ) { | ||
| case 'fixed': | ||
| array_push( $filters, "status = 'fixed'" ); |
There was a problem hiding this comment.
$filters[] = "status = 'fixed'"; It is the preferred way when doing MW development. Similarly below.
|
Looks good. Left some inline comments. |
Minor styling and HTML semantic changes Bug: T132352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.