Fix for Carthage to Build #28
Conversation
It was found that tests were interfering with SQift builds using carthage, a small change allows them to build, and Xcode to test each Scheme.
There was a problem hiding this comment.
A few small nits. Looks good overall @eSpecialized. If you have time, let's get this pushed out today!
CHANGELOG.md
Outdated
| @@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| #### 5.x Releases | |||
|
|
|||
| - `5.0.x` Releases - [5.0.0](#500) | |||
| - `5.0.x` Releases - [5.0.0](#500)||[5.0.1](#501) | |||
There was a problem hiding this comment.
[5.0.0](#500)||[5.0.1](#501) -> [5.0.0](#500) | [5.0.1](#501). It's just for markdown formatting.
CHANGELOG.md
Outdated
| @@ -41,6 +41,17 @@ All notable changes to this project will be documented in this file. | |||
| - `0.2.x` Releases - [0.2.0](#020) | |||
| - `0.1.x` Releases - [0.1.0](#010) | |||
|
|
|||
| ## [5.0.1](https://github.com/Nike-Inc/SQift/releases/tag/5.0.1) | |||
|
|
|||
| Release on 2019-06-13. All issues associated with this milestone can be found using this | |||
There was a problem hiding this comment.
Release on 2019-06-13. All -> Released on 2019-06-27. All.
There was a problem hiding this comment.
Still not correct. Should be Released and there's an extra space between . All.
CHANGELOG.md
Outdated
|
|
||
| #### Updated | ||
|
|
||
| - Fixes Carthage build issues with failing tests. Updates to Scheme's allows carthage to do the build. |
There was a problem hiding this comment.
How about?
- Fixed issue where Carthage was unable to build SQift due to schemes requiring test suite compilation.
- Fixed by [William]...
There was a problem hiding this comment.
This is still not quite right. Both should start with Fixed and typo in was. Second line is indented two spaces.
eSpecialized
force-pushed
the
carthage-fixes
branch
from
ebd577f
to
828da24
Compare
Found the CI’s failing on Travis, so I re-added to the tests in the scheme to get CI working.
eSpecialized
force-pushed
the
carthage-fixes
branch
from
828da24
to
0f436cc
Compare
It was found that tests were interfering with SQift builds using carthage, a small change allows them to build, and Xcode to test each Scheme.
It was found that tests were interfering with SQift builds using carthage, a small change allows them to build, and Xcode to test each Scheme.
|
Hey @eSpecialized, I've just merged a modified version of these changes in f88de59. They'll go out shortly as part of the 5.0.1 release. Thank again for putting this together! 🍻 |
We found that tests were interfering with SQift builds using carthage, a small change allows them to build, and Xcode to test each Scheme